update cs/index-out-of-bounds to match javascript/go

erik-krogh · erik-krogh · commit 49a3e208d795 · 2022-08-22T21:41:46.000+02:00
diff --git a/csharp/ql/src/Likely Bugs/Collections/ContainerLengthCmpOffByOne.ql b/csharp/ql/src/Likely Bugs/Collections/ContainerLengthCmpOffByOne.ql
@@ -64,6 +64,5 @@ where
     validGuard.controls(array, index) and
     validGuard.guards(indexAccess, _)
   )
-select incorrectGuard,
-  "Off-by-one index comparison against length leads to possible out of bounds $@.", ea,
-  ea.toString()
+select incorrectGuard, "Off-by-one index comparison against length may lead to out-of-bounds $@.",
+  ea, ea.toString()

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,5 @@ where`
`64`	`64`	`validGuard.controls(array, index) and`
`65`	`65`	`validGuard.guards(indexAccess, _)`
`66`	`66`	`)`
`67`		`-select incorrectGuard,`
`68`		`- "Off-by-one index comparison against length leads to possible out of bounds $@.", ea,`
`69`		`- ea.toString()`
	`67`	`+select incorrectGuard, "Off-by-one index comparison against length may lead to out-of-bounds $@.",`
	`68`	`+ ea, ea.toString()`