CPP: Detect Microsoft compilations somewhat more reliably.

geoffw0 · geoffw0 · commit 4a25c37eccfd · 2019-03-29T11:18:31.000Z
diff --git a/cpp/ql/src/semmle/code/cpp/File.qll b/cpp/ql/src/semmle/code/cpp/File.qll
@@ -302,7 +302,10 @@ class File extends Container, @file {
   predicate compiledAsMicrosoft() {
     exists(Compilation c |
       c.getAFileCompiled() = this and
-      c.getAnArgument() = "--microsoft"
+      (
+        c.getAnArgument() = "--microsoft" or
+        c.getAnArgument().matches("%\\\\cl.exe")
+      )
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,10 @@ class File extends Container, @file {`
`302`	`302`	`predicate compiledAsMicrosoft() {`
`303`	`303`	`exists(Compilation c \|`
`304`	`304`	`c.getAFileCompiled() = this and`
`305`		`- c.getAnArgument() = "--microsoft"`
	`305`	`+ (`
	`306`	`+ c.getAnArgument() = "--microsoft" or`
	`307`	`+ c.getAnArgument().matches("%\\\\cl.exe")`
	`308`	`+ )`
`306`	`309`	`)`
`307`	`310`	`}`
`308`	`311`