Apply suggestions from code review

yoff · RasmusWL · web-flow · commit 4a5fa5993d45 · 2022-08-25T10:47:16.000+02:00
Co-authored-by: Rasmus Wriedt Larsen &lt;rasmuswriedtlarsen@gmail.com&gt;
diff --git a/python/ql/lib/semmle/python/ApiGraphs.qll b/python/ql/lib/semmle/python/ApiGraphs.qll
@@ -605,7 +605,7 @@ module API {
     }
 
     /**
-     * Holds is them module `name` is imported.
+     * Holds if the module `name` is imported.
      *
      * This is determined syntactically.
      */
diff --git a/python/ql/lib/semmle/python/dataflow/new/FlowSummary.qll b/python/ql/lib/semmle/python/dataflow/new/FlowSummary.qll
@@ -1,7 +1,7 @@
 /** Provides classes and predicates for defining flow summaries. */
 
-import python
-import semmle.python.dataflow.new.DataFlow
+private import python
+private import semmle.python.dataflow.new.DataFlow
 private import internal.FlowSummaryImpl as Impl
 private import internal.DataFlowUtil
 private import internal.DataFlowPrivate
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatchPointsTo.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatchPointsTo.qll
@@ -465,11 +465,11 @@ abstract class DataFlowCall extends TDataFlowCall {
 
   /**
    * Gets the argument to this call that will be sent
-   * to the `n`th parameter of the callable, if such exists.
+   * to the `n`th parameter of the callable, if any.
    */
   abstract Node getArg(int n);
 
-  /** Get the control flow node representing this call, if such exists. */
+  /** Get the control flow node representing this call, if any. */
   abstract ControlFlowNode getNode();
 
   /** Gets the location of this dataflow call. */
@@ -655,7 +655,7 @@ class LibraryCall extends NormalCall {
  * map(lambda x: x + 1, [1, 2, 3])
  * ```
  *
- * there is a call to the lambda argument inside `map`.
+ * there is a synthesized call to the lambda argument inside `map`.
  */
 class SummaryCall extends DataFlowCall, TSummaryCall {
   private FlowSummaryImpl::Public::SummarizedCallable c;

Original file line number	Diff line number	Diff line change
`@@ -605,7 +605,7 @@ module API {`
`605`	`605`	`}`
`606`	`606`
`607`	`607`	`/**`
`608`		- * Holds is them module `name` is imported.
	`608`	+ * Holds if the module `name` is imported.
`609`	`609`	`*`
`610`	`610`	`* This is determined syntactically.`
`611`	`611`	`*/`