JS: Fix and expand test cases

asgerf · asgerf · commit 4c25d84b6e80 · 2020-01-06T14:43:29.000Z
diff --git a/javascript/ql/test/query-tests/RegExp/RegExpAlwaysMatches/tst.js b/javascript/ql/test/query-tests/RegExp/RegExpAlwaysMatches/tst.js
@@ -3,7 +3,7 @@ function optionalPrefix(x) {
 }
 
 function mandatoryPrefix(x) {
-  return /^https:/.test(x); // NOT OK
+  return /^https:/.test(x); // OK
 }
 
 function httpOrHttps(x) {
@@ -65,3 +65,11 @@ function search2(x) {
 function lookahead(x) {
   return /(?!x)/.search(x); // OK
 }
+
+function searchPrefix(x) {
+  return /^foo?/.search(x); // NOT OK - `foo?` does not affect the returned index
+}
+
+function searchSuffix(x) {
+  return /foo?$/.search(x); // OK - `foo?` affects the returned index
+}

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ function optionalPrefix(x) {`
`3`	`3`	`}`
`4`	`4`
`5`	`5`	`function mandatoryPrefix(x) {`
`6`		`- return /^https:/.test(x); // NOT OK`
	`6`	`+ return /^https:/.test(x); // OK`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`function httpOrHttps(x) {`
`@@ -65,3 +65,11 @@ function search2(x) {`
`65`	`65`	`function lookahead(x) {`
`66`	`66`	`return /(?!x)/.search(x); // OK`
`67`	`67`	`}`
	`68`	`+`
	`69`	`+function searchPrefix(x) {`
	`70`	+ return /^foo?/.search(x); // NOT OK - `foo?` does not affect the returned index
	`71`	`+}`
	`72`	`+`
	`73`	`+function searchSuffix(x) {`
	`74`	+ return /foo?$/.search(x); // OK - `foo?` affects the returned index
	`75`	`+}`