Remove unnecessary import

atorralba · atorralba · commit 4dd9e7d6a003 · 2021-10-18T11:10:22.000+02:00
Add comment
diff --git a/java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll b/java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll
@@ -70,8 +70,10 @@ private class TaintedIntentComponentConf extends TaintTracking2::Configuration {
 
 /** Holds if `expr` modifies the component of an `Intent`. */
 private predicate changesIntentComponent(Expr expr) {
-  any(IntentGetParcelableExtra igpe) = expr or
   any(IntentSetComponent isc).getSink() = expr
+  or
+  // obtaining an arbitrary Intent as a Parcelable extra
+  expr instanceof IntentGetParcelableExtra
 }
 
 /** A call to the method `Intent.getParcelableExtra`. */
diff --git a/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.ql b/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.ql
@@ -14,7 +14,6 @@
  */
 
 import java
-import semmle.code.java.dataflow.DataFlow
 import semmle.code.java.security.AndroidIntentRedirectionQuery
 import DataFlow::PathGraph
 
