C#: Fix dataflow.

calumgrant · calumgrant · commit 5144f89a5bbb · 2019-01-31T19:53:46.000Z
diff --git a/csharp/ql/src/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll b/csharp/ql/src/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll
@@ -85,7 +85,7 @@ private module Cached {
     exists(LibraryTypeDataFlow ltdf, CallableFlowSource csource, CallableFlowSinkDelegateArg csink |
       ltdf.callableFlow(csource, csink, callable, preservesValue) and
       call.getTarget().getSourceDeclaration() = callable and
-      csink = getDelegateFlowSinkArg(callable, i, j) and
+      csink = getDelegateFlowSinkArg(callable, j, i) and
       source = csource.getSource(call)
     )
   }
@@ -107,7 +107,7 @@ private module Cached {
       ltdf.callableFlow(csource, csink, callable, preservesValue) and
       call.getTarget().getSourceDeclaration() = callable and
       csource = getDelegateFlowSourceArg(callable, i) and
-      csink = getDelegateFlowSinkArg(callable, j, k)
+      csink = getDelegateFlowSinkArg(callable, k, j)
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ private module Cached {`
`85`	`85`	`exists(LibraryTypeDataFlow ltdf, CallableFlowSource csource, CallableFlowSinkDelegateArg csink \|`
`86`	`86`	`ltdf.callableFlow(csource, csink, callable, preservesValue) and`
`87`	`87`	`call.getTarget().getSourceDeclaration() = callable and`
`88`		`- csink = getDelegateFlowSinkArg(callable, i, j) and`
	`88`	`+ csink = getDelegateFlowSinkArg(callable, j, i) and`
`89`	`89`	`source = csource.getSource(call)`
`90`	`90`	`)`
`91`	`91`	`}`
`@@ -107,7 +107,7 @@ private module Cached {`
`107`	`107`	`ltdf.callableFlow(csource, csink, callable, preservesValue) and`
`108`	`108`	`call.getTarget().getSourceDeclaration() = callable and`
`109`	`109`	`csource = getDelegateFlowSourceArg(callable, i) and`
`110`		`- csink = getDelegateFlowSinkArg(callable, j, k)`
	`110`	`+ csink = getDelegateFlowSinkArg(callable, k, j)`
`111`	`111`	`)`
`112`	`112`	`}`
`113`	`113`	`}`