JS: fix FPs in DeadStoreOfLocal

asger-semmle · asger-semmle · commit 51fe31d04931 · 2019-02-04T14:21:34.000Z
diff --git a/javascript/ql/src/Declarations/DeadStoreOfLocal.ql b/javascript/ql/src/Declarations/DeadStoreOfLocal.ql
@@ -49,5 +49,7 @@ where
   // don't flag assignments in externs
   not dead.(ASTNode).inExternsFile() and
   // don't flag exported variables
-  not any(ES2015Module m).exportsAs(v, _)
+  not any(ES2015Module m).exportsAs(v, _) and
+  // don't flag 'exports' assignments in closure modules
+  not any(Closure::ClosureModule mod).getExportsVariable() = v
 select dead, "This definition of " + v.getName() + " is useless, since its value is never read."
