Improve QL check for path match on netcore.app.ref in exluded assemblies

tamasvajk · tamasvajk · commit 53054290d1f2 · 2021-06-23T09:26:54.000+02:00
diff --git a/csharp/ql/src/Stubs/AllStubsFromReference.ql b/csharp/ql/src/Stubs/AllStubsFromReference.ql
@@ -12,9 +12,7 @@ class AllExternalPublicDeclarations extends GeneratedDeclaration {
 
 /** All framework assemblies. */
 class NonTargetAssembly extends ExcludedAssembly {
-  NonTargetAssembly() {
-    exists(this.getFile().getAbsolutePath().indexOf("Microsoft.NETCore.App.Ref"))
-  }
+  NonTargetAssembly() { this.getFile().getAbsolutePath().matches("%Microsoft.NETCore.App.Ref%") }
 }
 
 from Assembly a

Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,7 @@ class AllExternalPublicDeclarations extends GeneratedDeclaration {`
`12`	`12`
`13`	`13`	`/** All framework assemblies. */`
`14`	`14`	`class NonTargetAssembly extends ExcludedAssembly {`
`15`		`- NonTargetAssembly() {`
`16`		`- exists(this.getFile().getAbsolutePath().indexOf("Microsoft.NETCore.App.Ref"))`
`17`		`- }`
	`15`	`+ NonTargetAssembly() { this.getFile().getAbsolutePath().matches("%Microsoft.NETCore.App.Ref%") }`
`18`	`16`	`}`
`19`	`17`
`20`	`18`	`from Assembly a`