Simplify getCaseIndex

smowton · smowton · commit 5511955b604f · 2023-11-30T11:24:05.000Z
diff --git a/java/ql/lib/semmle/code/java/Statement.qll b/java/ql/lib/semmle/code/java/Statement.qll
@@ -461,7 +461,7 @@ class SwitchCase extends Stmt, @case {
    * Gets this case's ordinal in its switch block.
    */
   int getCaseIndex() {
-    this = this.getSwitch().getCase(result) or this = this.getSwitchExpr().getCase(result)
+    this = any(SwitchStmt ss).getCase(result) or this = any(SwitchExpr se).getCase(result)
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -461,7 +461,7 @@ class SwitchCase extends Stmt, @case {`
`461`	`461`	`* Gets this case's ordinal in its switch block.`
`462`	`462`	`*/`
`463`	`463`	`int getCaseIndex() {`
`464`		`- this = this.getSwitch().getCase(result) or this = this.getSwitchExpr().getCase(result)`
	`464`	`+ this = any(SwitchStmt ss).getCase(result) or this = any(SwitchExpr se).getCase(result)`
`465`	`465`	`}`
`466`	`466`
`467`	`467`	`/**`