C++: Address review comments.

MathiasVP · MathiasVP · commit 55615586eed1 · 2021-02-04T11:30:44.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/Strset.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/Strset.qll
@@ -40,9 +40,6 @@ private class StrsetFunction extends ArrayFunction, DataFlowFunction, AliasFunct
     // flow from the input string to the output string
     input.isParameter(0) and
     output.isReturnValue()
-    or
-    input.isParameterDeref(0) and
-    output.isReturnValueDeref()
   }
 
   override predicate parameterNeverEscapes(int index) { none() }

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,6 @@ private class StrsetFunction extends ArrayFunction, DataFlowFunction, AliasFunct`
`40`	`40`	`// flow from the input string to the output string`
`41`	`41`	`input.isParameter(0) and`
`42`	`42`	`output.isReturnValue()`
`43`		`- or`
`44`		`- input.isParameterDeref(0) and`
`45`		`- output.isReturnValueDeref()`
`46`	`43`	`}`
`47`	`44`
`48`	`45`	`override predicate parameterNeverEscapes(int index) { none() }`