JS: add test for js/trivial-conditional

Esben Sparre Andreasen · Esben Sparre Andreasen · commit 55fd948c2492 · 2019-02-07T11:41:36.000+01:00
diff --git a/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.expected b/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.expected
@@ -33,3 +33,5 @@
 | UselessConditionalGood.js:69:12:69:13 | xy | This use of variable 'xy' always evaluates to false. |
 | UselessConditionalGood.js:85:12:85:13 | xy | This use of variable 'xy' always evaluates to false. |
 | UselessConditionalGood.js:97:12:97:13 | xy | This use of variable 'xy' always evaluates to false. |
+| UselessConditionalGood.js:114:8:114:8 | p | This use of variable 'p' always evaluates to false. |
+| UselessConditionalGood.js:122:8:122:8 | p | This use of variable 'p' always evaluates to false. |
diff --git a/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditionalGood.js b/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditionalGood.js
@@ -99,3 +99,30 @@ function getLastLine(input) {
     f10(undefined, undefined);
 
 })();
+
+(function(){
+	function g(p) {
+		return function() {
+			if (p) { // OK, whitelisted
+				g(p);
+			}
+		};
+	}
+
+	function f(p = false) {
+		return function() {
+			if (p) { // OK, whitelisted
+				f(p);
+			}
+		};
+	}
+
+	function h(p = false) {
+		(function() {
+			if (p) { // OK, whitelisted
+
+			}
+		});
+	}
+	h();
+});
