JS: Add test case for wide constants in char class

asger-semmle · asger-semmle · commit 591fffc5cc80 · 2019-11-15T09:27:19.000Z
diff --git a/javascript/ql/test/library-tests/RegExp/MissingUnicodeFlag/MissingUnicodeFlag.expected b/javascript/ql/test/library-tests/RegExp/MissingUnicodeFlag/MissingUnicodeFlag.expected
@@ -0,0 +1 @@
+| tst.js:1:1:1:9 | /[\\u12340\\udf40-\\u12345\\udf45]/ | Character class with supplementary characters in non-unicode literal. |
diff --git a/javascript/ql/test/library-tests/RegExp/MissingUnicodeFlag/MissingUnicodeFlag.ql b/javascript/ql/test/library-tests/RegExp/MissingUnicodeFlag/MissingUnicodeFlag.ql
@@ -0,0 +1,12 @@
+import javascript
+
+from RegExpLiteral literal, RegExpConstant wideConstant
+where wideConstant.getLiteral() = literal and
+  not literal.getFlags().matches("%u%") and
+  wideConstant.getValue().length() > 1 and
+  (
+    wideConstant.getParent() instanceof RegExpCharacterClass
+    or
+    wideConstant.getParent() instanceof RegExpCharacterRange
+  )
+select literal, "Character class with supplementary characters in non-unicode literal."
diff --git a/javascript/ql/test/library-tests/RegExp/MissingUnicodeFlag/tst.js b/javascript/ql/test/library-tests/RegExp/MissingUnicodeFlag/tst.js
@@ -0,0 +1,2 @@
+/[𒍀-𒍅]/; // NOT OK
+/[𒍀-𒍅]/u; // OK

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+\| tst.js:1:1:1:9 \| /[\\u12340\\udf40-\\u12345\\udf45]/ \| Character class with supplementary characters in non-unicode literal. \|`