Python: Add test of API::moduleImport with dots

RasmusWL · RasmusWL · commit 597a8414d99d · 2022-05-12T13:29:16.000+02:00
This is currently semi-works -- the import is allowed, but doesn't
always work when used :|
diff --git a/python/ql/test/library-tests/ApiGraphs/py3/ModuleImportWithDots.expected b/python/ql/test/library-tests/ApiGraphs/py3/ModuleImportWithDots.expected
@@ -0,0 +1,7 @@
+moduleImportWithDots
+| file://:0:0:0:0 | ModuleImport moduleImport("a").getMember("b").getMember("c").getMember("d") |
+doesntFullyWork
+| test.py:28:10:28:17 | ControlFlowNode for method() |
+works
+| test.py:25:6:25:18 | ControlFlowNode for Attribute() |
+| test.py:28:10:28:17 | ControlFlowNode for method() |
diff --git a/python/ql/test/library-tests/ApiGraphs/py3/ModuleImportWithDots.ql b/python/ql/test/library-tests/ApiGraphs/py3/ModuleImportWithDots.ql
@@ -0,0 +1,18 @@
+private import python
+private import semmle.python.ApiGraphs
+
+query API::Node moduleImportWithDots() { result = API::moduleImport("a.b.c.d") }
+
+query API::CallNode doesntFullyWork() {
+  result = API::moduleImport("a.b.c.d").getMember("method").getACall()
+}
+
+query API::CallNode works() {
+  result =
+    API::moduleImport("a")
+        .getMember("b")
+        .getMember("c")
+        .getMember("d")
+        .getMember("method")
+        .getACall()
+}
diff --git a/python/ql/test/library-tests/ApiGraphs/py3/test.py b/python/ql/test/library-tests/ApiGraphs/py3/test.py
@@ -24,6 +24,9 @@
 
 x5 = abcd.method() #$ use=moduleImport("a").getMember("b").getMember("c").getMember("d").getMember("method").getReturn()
 
+from a.b.c.d import method
+x5_alt = method() #$ use=moduleImport("a").getMember("b").getMember("c").getMember("d").getMember("method").getReturn()
+
 from a6 import m6 #$ use=moduleImport("a6").getMember("m6")
 
 x6 = m6().foo().bar() #$ use=moduleImport("a6").getMember("m6").getReturn().getMember("foo").getReturn().getMember("bar").getReturn()
diff --git a/python/ql/test/library-tests/ApiGraphs/py3/verifyApiGraphs.ql b/python/ql/test/library-tests/ApiGraphs/py3/verifyApiGraphs.ql
@@ -1 +1,3 @@
+// Note: This is not using standard inline-expectation tests, so will not alert if you
+// have not manually added an annotation to a line!
 import TestUtilities.VerifyApiGraphs

Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+// Note: This is not using standard inline-expectation tests, so will not alert if you`
	`2`	`+// have not manually added an annotation to a line!`
`1`	`3`	`import TestUtilities.VerifyApiGraphs`