C++: Fix TODO.

MathiasVP · MathiasVP · commit 5ae322892844 · 2022-12-07T22:34:10.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll
@@ -292,9 +292,8 @@ predicate outNodeHasAddressAndIndex(
 }
 
 private predicate defToNode(Node nodeFrom, Def def) {
-  // TODO: This is not yet needed (and in fact, the compiler rejects it because `exists(def.getValue().asOperand())` never holds).
-  // nodeHasOperand(nodeFrom, def.getValue().asOperand(), def.getIndirectionIndex())
-  // or
+  nodeHasOperand(nodeFrom, def.getValue().asOperand(), def.getIndirectionIndex())
+  or
   nodeHasInstruction(nodeFrom, def.getValue().asInstruction(), def.getIndirectionIndex())
 }
 

Original file line number	Diff line number	Diff line change
`@@ -292,9 +292,8 @@ predicate outNodeHasAddressAndIndex(`
`292`	`292`	`}`
`293`	`293`
`294`	`294`	`private predicate defToNode(Node nodeFrom, Def def) {`
`295`		- // TODO: This is not yet needed (and in fact, the compiler rejects it because `exists(def.getValue().asOperand())` never holds).
`296`		`- // nodeHasOperand(nodeFrom, def.getValue().asOperand(), def.getIndirectionIndex())`
`297`		`- // or`
	`295`	`+ nodeHasOperand(nodeFrom, def.getValue().asOperand(), def.getIndirectionIndex())`
	`296`	`+ or`
`298`	`297`	`nodeHasInstruction(nodeFrom, def.getValue().asInstruction(), def.getIndirectionIndex())`
`299`	`298`	`}`
`300`	`299`