Removes conflicting NumericValue definition

BekaValentine · BekaValentine · commit 5d9d724d43d5 · 2020-02-20T16:17:33.000-08:00
diff --git a/python/ql/src/semmle/python/objects/ObjectAPI.qll b/python/ql/src/semmle/python/objects/ObjectAPI.qll
@@ -144,62 +144,6 @@ class Value extends TObject {
     }
 }
 
-/** Numeric values (ints and floats). 
- *  Includes those occurring in the source as a literal
- *  or in a builtin module as a value.
- */
-class NumericValue extends Value {
-
-    NumericValue() {
-        this.asBuiltin().getClass() = theIntType().asBuiltin() or
-        this.asBuiltin().getClass() = theLongType().asBuiltin() or
-        this.asBuiltin().getClass() = theFloatType().asBuiltin()
-    }
-
-    /** Gets the Boolean value that this object
-     *  would evaluate to in a Boolean context,
-     * such as `bool(x)` or `if x: ...`
-     */
-    override boolean booleanValue() {
-        this.intValue() != 0 and result = true
-        or
-        this.intValue() = 0 and result = false
-        or
-        this.floatValue() != 0 and result = true
-        or
-        this.floatValue() = 0 and result = false
-    }
-
-    /** Gets the value of this object if it is a constant integer and it fits in a QL int */ 
-    int intValue() {
-        (
-            this.asBuiltin().getClass() = theIntType().asBuiltin() or
-            this.asBuiltin().getClass() = theLongType().asBuiltin()
-        )
-        and
-        result = this.asBuiltin().getName().toInt()
-    }
-
-    /** Gets the value of this object if it is a constant float */ 
-    float floatValue() {
-        this.asBuiltin().getClass() = theFloatType().asBuiltin()
-        and
-        result = this.asBuiltin().getName().toFloat()
-    }
-
-    /** Gets the string representation of this object, equivalent to calling repr() in Python */
-    string repr() {
-        exists(string s |
-            s = this.asBuiltin().getName() |
-            if this.asBuiltin().getClass() = theLongType().asBuiltin() then
-                result = s + "L"
-            else
-                result = s
-        )
-    }
-
-}
-
 /** Class representing modules in the Python program
  * Each `ModuleValue` represents a module object in the Python program.
  */
