JS: Tolerate Angular-specific HTML attribute names

asgerf · asgerf · commit 5fa3b1795685 · 2021-01-15T14:51:10.000Z
diff --git a/javascript/extractor/src/com/semmle/js/extractor/HTMLExtractor.java b/javascript/extractor/src/com/semmle/js/extractor/HTMLExtractor.java
@@ -144,6 +144,9 @@ public HTMLExtractor(ExtractorConfig config, ExtractorState state) {
 
   @Override
   public LoCInfo extract(TextualExtractor textualExtractor) {
+    // Angular templates contain attribute names that are not valid HTML/XML, such as [foo], (foo), [(foo)], and *foo.
+    // Allow a large number of errors in attribute names, so the Jericho parser does not give up.
+    Attributes.setDefaultMaxErrorCount(100);
     JavaScriptHTMLElementHandler eltHandler = new JavaScriptHTMLElementHandler(textualExtractor);
 
     HtmlPopulator extractor =
