Make all imports of cpp private

dave-bartolomeo · dave-bartolomeo · commit 60b3ffe3d59b · 2019-07-16T15:02:26.000-07:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/IRConfiguration.qll b/cpp/ql/src/semmle/code/cpp/ir/IRConfiguration.qll
@@ -1,4 +1,4 @@
-import cpp
+private import cpp
 
 private newtype TIRConfiguration = MkIRConfiguration()
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/ValueCategory.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/ValueCategory.qll
@@ -1,4 +1,4 @@
-import cpp
+private import cpp
 
 private newtype TValueCategory =
   TLValue() or
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/IRFunction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/IRFunction.qll
@@ -1,6 +1,6 @@
 private import internal.IRInternal
 import Instruction
-import cpp
+private import cpp
 
 private newtype TIRFunction =
   MkIRFunction(Function func) {
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/IRVariable.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/IRVariable.qll
@@ -1,6 +1,6 @@
 private import internal.IRInternal
 import IRFunction
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.TempVariableTag
 private import semmle.code.cpp.ir.internal.IRUtilities
 private import semmle.code.cpp.ir.internal.TempVariableTag
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
@@ -3,7 +3,7 @@ import IRFunction
 import IRBlock
 import IRVariable
 import Operand
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.EdgeKind
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.implementation.Opcode
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Operand.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Operand.qll
@@ -1,7 +1,7 @@
 private import internal.IRInternal
 import Instruction
 import IRBlock
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.internal.Overlap
 private import semmle.code.cpp.ir.internal.OperandTag
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/PrintIR.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/PrintIR.qll
@@ -1,5 +1,5 @@
 private import IR
-import cpp
+private import cpp
 import semmle.code.cpp.ir.IRConfiguration
 private import semmle.code.cpp.Print
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/ValueNumbering.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/ValueNumbering.qll
@@ -1,5 +1,5 @@
 private import internal.ValueNumberingInternal
-import cpp
+private import cpp
 private import IR
 
 /**
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasAnalysis.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasAnalysis.qll
@@ -1,5 +1,5 @@
 private import AliasAnalysisInternal
-import cpp
+private import cpp
 private import InputIR
 private import semmle.code.cpp.ir.internal.IntegerConstant as Ints
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll
@@ -1,5 +1,5 @@
 import SSAConstructionInternal
-import cpp
+private import cpp
 private import semmle.code.cpp.ir.implementation.Opcode
 private import semmle.code.cpp.ir.internal.OperandTag
 private import semmle.code.cpp.ir.internal.Overlap
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/IRFunction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/IRFunction.qll
@@ -1,6 +1,6 @@
 private import internal.IRInternal
 import Instruction
-import cpp
+private import cpp
 
 private newtype TIRFunction =
   MkIRFunction(Function func) {
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/IRVariable.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/IRVariable.qll
@@ -1,6 +1,6 @@
 private import internal.IRInternal
 import IRFunction
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.TempVariableTag
 private import semmle.code.cpp.ir.internal.IRUtilities
 private import semmle.code.cpp.ir.internal.TempVariableTag
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll
@@ -3,7 +3,7 @@ import IRFunction
 import IRBlock
 import IRVariable
 import Operand
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.EdgeKind
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.implementation.Opcode
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Operand.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Operand.qll
@@ -1,7 +1,7 @@
 private import internal.IRInternal
 import Instruction
 import IRBlock
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.internal.Overlap
 private import semmle.code.cpp.ir.internal.OperandTag
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/PrintIR.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/PrintIR.qll
@@ -1,5 +1,5 @@
 private import IR
-import cpp
+private import cpp
 import semmle.code.cpp.ir.IRConfiguration
 private import semmle.code.cpp.Print
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/gvn/ValueNumbering.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/gvn/ValueNumbering.qll
@@ -1,5 +1,5 @@
 private import internal.ValueNumberingInternal
-import cpp
+private import cpp
 private import IR
 
 /**
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/IRFunction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/IRFunction.qll
@@ -1,6 +1,6 @@
 private import internal.IRInternal
 import Instruction
-import cpp
+private import cpp
 
 private newtype TIRFunction =
   MkIRFunction(Function func) {
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/IRVariable.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/IRVariable.qll
@@ -1,6 +1,6 @@
 private import internal.IRInternal
 import IRFunction
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.TempVariableTag
 private import semmle.code.cpp.ir.internal.IRUtilities
 private import semmle.code.cpp.ir.internal.TempVariableTag
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -3,7 +3,7 @@ import IRFunction
 import IRBlock
 import IRVariable
 import Operand
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.EdgeKind
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.implementation.Opcode
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Operand.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Operand.qll
@@ -1,7 +1,7 @@
 private import internal.IRInternal
 import Instruction
 import IRBlock
-import cpp
+private import cpp
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.internal.Overlap
 private import semmle.code.cpp.ir.internal.OperandTag
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/PrintIR.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/PrintIR.qll
@@ -1,5 +1,5 @@
 private import IR
-import cpp
+private import cpp
 import semmle.code.cpp.ir.IRConfiguration
 private import semmle.code.cpp.Print
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/gvn/ValueNumbering.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/gvn/ValueNumbering.qll
@@ -1,5 +1,5 @@
 private import internal.ValueNumberingInternal
-import cpp
+private import cpp
 private import IR
 
 /**
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll
@@ -1,5 +1,5 @@
 private import AliasAnalysisInternal
-import cpp
+private import cpp
 private import InputIR
 private import semmle.code.cpp.ir.internal.IntegerConstant as Ints
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll
@@ -1,5 +1,5 @@
 import SSAConstructionInternal
-import cpp
+private import cpp
 private import semmle.code.cpp.ir.implementation.Opcode
 private import semmle.code.cpp.ir.internal.OperandTag
 private import semmle.code.cpp.ir.internal.Overlap
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SimpleSSA.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SimpleSSA.qll
@@ -1,5 +1,5 @@
 import AliasAnalysis
-import cpp
+private import cpp
 private import semmle.code.cpp.ir.implementation.raw.IR
 private import semmle.code.cpp.ir.internal.IntegerConstant as Ints
 private import semmle.code.cpp.ir.internal.OperandTag
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/IRUtilities.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/IRUtilities.qll
@@ -1,4 +1,4 @@
-import cpp
+private import cpp
 
 /**
  * Given a type, get the type that would result by applying "pointer decay".
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/IntegerConstant.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/IntegerConstant.qll
@@ -1,4 +1,4 @@
-import cpp
+private import cpp
 
 class IntValue = int;
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/OperandTag.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/OperandTag.qll
@@ -1,4 +1,4 @@
-import cpp
+private import cpp
 
 private int getMaxCallArgIndex() {
   result = max(int argIndex |
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/Overlap.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/Overlap.qll
@@ -1,4 +1,4 @@
-import cpp
+private import cpp
 
 private newtype TOverlap =
   TMayPartiallyOverlap() or
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/TempVariableTag.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/TempVariableTag.qll
@@ -1,4 +1,4 @@
-import cpp
+private import cpp
 
 newtype TTempVariableTag =
   ConditionValueTempVar() or

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import cpp`
	`1`	`+private import cpp`
`2`	`2`
`3`	`3`	`private newtype TIRConfiguration = MkIRConfiguration()`
`4`	`4`