Update cpp/ql/src/experimental/Security/CWE/CWE-266/IncorrectPrivilegeAssignment.ql

ihsinme · geoffw0 · web-flow · commit 6168b15bbcf1 · 2021-11-19T08:56:21.000+03:00
Co-authored-by: Geoffrey White &lt;40627776+geoffw0@users.noreply.github.com&gt;
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-266/IncorrectPrivilegeAssignment.ql b/cpp/ql/src/experimental/Security/CWE/CWE-266/IncorrectPrivilegeAssignment.ql
@@ -46,7 +46,7 @@ where
   fc.getArgument(0).getValue() = "0" and
   not exists(FunctionCall fctmp |
     fctmp.getTarget().hasGlobalOrStdName("umask") and
-    fctmp.getArgument(0).getValue() != "0"
+    not fctmp.getArgument(0).getValue() = "0"
   ) and
   exists(FunctionCall fctmp |
     (

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ where`
`46`	`46`	`fc.getArgument(0).getValue() = "0" and`
`47`	`47`	`not exists(FunctionCall fctmp \|`
`48`	`48`	`fctmp.getTarget().hasGlobalOrStdName("umask") and`
`49`		`- fctmp.getArgument(0).getValue() != "0"`
	`49`	`+ not fctmp.getArgument(0).getValue() = "0"`
`50`	`50`	`) and`
`51`	`51`	`exists(FunctionCall fctmp \|`
`52`	`52`	`(`