Apply suggestions from code review

atorralba · aschackmull · web-flow · commit 62f847a82e08 · 2022-01-20T13:44:10.000+01:00
Co-authored-by: Anders Schack-Mulligen &lt;aschackmull@users.noreply.github.com&gt;
diff --git a/java/ql/lib/semmle/code/java/frameworks/android/OnActivityResultSource.qll b/java/ql/lib/semmle/code/java/frameworks/android/OnActivityResultSource.qll
@@ -46,7 +46,7 @@ class OnActivityResultIncomingIntent extends DataFlow::Node {
             .getDeclaringType()
             .hasQualifiedName(["android.app", "android.support.v4.app", "androidx.fragment.app"],
               "FragmentTransaction") and
-        any(Argument arg | arg = ma.getAnArgument()).getType() = startingType
+        ma.getAnArgument().getType() = startingType
         or
         ma.getMethod().hasName("show") and
         ma.getMethod()
diff --git a/java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSourceTest.ql b/java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSourceTest.ql
@@ -3,7 +3,7 @@ import semmle.code.java.dataflow.FlowSources
 import TestUtilities.InlineFlowTest
 
 class SourceValueFlowConf extends DefaultValueFlowConf {
-  override predicate isSource(DataFlow::Node sink) { sink instanceof RemoteFlowSource }
+  override predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }
 }
 
 class SourceInlineFlowTest extends InlineFlowTest {

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import semmle.code.java.dataflow.FlowSources`
`3`	`3`	`import TestUtilities.InlineFlowTest`
`4`	`4`
`5`	`5`	`class SourceValueFlowConf extends DefaultValueFlowConf {`
`6`		`- override predicate isSource(DataFlow::Node sink) { sink instanceof RemoteFlowSource }`
	`6`	`+ override predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`class SourceInlineFlowTest extends InlineFlowTest {`