Java: Remove two unnecessary unbinds.

aschackmull · aschackmull · commit 648335d46db4 · 2019-09-20T16:12:56.000+02:00
diff --git a/java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl.qll b/java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl.qll
@@ -1175,12 +1175,12 @@ private predicate flowCand0(Node node, boolean toReturn, AccessPathFront apf, Co
   exists(Content f, AccessPathFront apf0 |
     flowCandStore(node, f, toReturn, apf0, config) and
     apf0.headUsesContent(f) and
-    consCand(f, apf, unbind(config))
+    consCand(f, apf, config)
   )
   or
   exists(Content f, AccessPathFront apf0 |
     flowCandRead(node, f, toReturn, apf0, config) and
-    consCandFwd(f, apf0, unbind(config)) and
+    consCandFwd(f, apf0, config) and
     apf.headUsesContent(f)
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -1175,12 +1175,12 @@ private predicate flowCand0(Node node, boolean toReturn, AccessPathFront apf, Co`
`1175`	`1175`	`exists(Content f, AccessPathFront apf0 \|`
`1176`	`1176`	`flowCandStore(node, f, toReturn, apf0, config) and`
`1177`	`1177`	`apf0.headUsesContent(f) and`
`1178`		`- consCand(f, apf, unbind(config))`
	`1178`	`+ consCand(f, apf, config)`
`1179`	`1179`	`)`
`1180`	`1180`	`or`
`1181`	`1181`	`exists(Content f, AccessPathFront apf0 \|`
`1182`	`1182`	`flowCandRead(node, f, toReturn, apf0, config) and`
`1183`		`- consCandFwd(f, apf0, unbind(config)) and`
	`1183`	`+ consCandFwd(f, apf0, config) and`
`1184`	`1184`	`apf.headUsesContent(f)`
`1185`	`1185`	`)`
`1186`	`1186`	`}`