C#: Fix PR review findings in NamespaceDeclaration

tamasvajk · tamasvajk · commit 64b584b4a392 · 2020-10-28T11:30:17.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/NamespaceDeclaration.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/NamespaceDeclaration.cs
@@ -8,7 +8,7 @@
 
 namespace Semmle.Extraction.CSharp.Entities
 {
-    class NamespaceDeclaration : CachedEntity<NamespaceDeclarationSyntax>
+    internal class NamespaceDeclaration : CachedEntity<NamespaceDeclarationSyntax>
     {
         private readonly NamespaceDeclaration parent;
         private readonly NamespaceDeclarationSyntax node;
@@ -49,10 +49,10 @@ public override void Populate(TextWriter trapFile)
         public static NamespaceDeclaration Create(Context cx, NamespaceDeclarationSyntax decl, NamespaceDeclaration parent)
         {
             var init = (decl, parent);
-            return NamespaceDeclarationFactory.Instance.CreateEntity(cx, init, init);
+            return NamespaceDeclarationFactory.Instance.CreateEntity(cx, decl, init);
         }
 
-        class NamespaceDeclarationFactory : ICachedEntityFactory<(NamespaceDeclarationSyntax decl, NamespaceDeclaration parent), NamespaceDeclaration>
+        private class NamespaceDeclarationFactory : ICachedEntityFactory<(NamespaceDeclarationSyntax decl, NamespaceDeclaration parent), NamespaceDeclaration>
         {
             public static readonly NamespaceDeclarationFactory Instance = new NamespaceDeclarationFactory();
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`
`9`	`9`	`namespace Semmle.Extraction.CSharp.Entities`
`10`	`10`	`{`
`11`		`- class NamespaceDeclaration : CachedEntity<NamespaceDeclarationSyntax>`
	`11`	`+ internal class NamespaceDeclaration : CachedEntity<NamespaceDeclarationSyntax>`
`12`	`12`	`{`
`13`	`13`	`private readonly NamespaceDeclaration parent;`
`14`	`14`	`private readonly NamespaceDeclarationSyntax node;`
`@@ -49,10 +49,10 @@ public override void Populate(TextWriter trapFile)`
`49`	`49`	`public static NamespaceDeclaration Create(Context cx, NamespaceDeclarationSyntax decl, NamespaceDeclaration parent)`
`50`	`50`	`{`
`51`	`51`	`var init = (decl, parent);`
`52`		`- return NamespaceDeclarationFactory.Instance.CreateEntity(cx, init, init);`
	`52`	`+ return NamespaceDeclarationFactory.Instance.CreateEntity(cx, decl, init);`
`53`	`53`	`}`
`54`	`54`
`55`		`- class NamespaceDeclarationFactory : ICachedEntityFactory<(NamespaceDeclarationSyntax decl, NamespaceDeclaration parent), NamespaceDeclaration>`
	`55`	`+ private class NamespaceDeclarationFactory : ICachedEntityFactory<(NamespaceDeclarationSyntax decl, NamespaceDeclaration parent), NamespaceDeclaration>`
`56`	`56`	`{`
`57`	`57`	`public static readonly NamespaceDeclarationFactory Instance = new NamespaceDeclarationFactory();`
`58`	`58`