<!DOCTYPE qhelp PUBLIC

"-//Semmle//qhelp//EN"

"qhelp.dtd">

<qhelp>

<overview>

<p>A function is called with arguments despite having an empty parameter list. This may indicate

that the incorrect function is being called, or that the author misunderstood the function.</p>

</overview>

<recommendation>

<p>Call the function without arguments, or call a different function that expects the arguments

being passed.</p>

</recommendation>

<example><sample src="FutileParams.c" />

</example>

<references>

<li>SEI CERT C++ Coding Standard: <a href="https://wiki.sei.cmu.edu/confluence/display/c/DCL20-C.+Explicitly+specify+void+when+a+function+accepts+no+arguments"> DCL20-C. Explicitly specify void when a function accepts no arguments </a></li>

</references>

</qhelp>

import cpp

from Function f, FunctionCall fc

where fc.getTarget() = f

and f.getNumberOfParameters() = 0

and not f.isVarargs()

and fc.getNumberOfArguments() != 0

and not f instanceof BuiltInFunction

and exists(FunctionDeclarationEntry fde | fde = f.getADeclarationEntry() | not fde.isImplicit())

select fc, "This call has arguments, but $@ is not declared with any parameters.", f, f.toString()

| test.c:7:3:7:5 | call to foo | This call has arguments, but $@ is not declared with any parameters. | test.c:1:6:1:8 | foo | foo |

| test.c:13:3:13:19 | call to not_yet_declared1 | This call has arguments, but $@ is not declared with any parameters. | test.c:13:3:13:3 | not_yet_declared1 | not_yet_declared1 |

| test.c:13:3:13:19 | call to not_yet_declared1 | This call has arguments, but $@ is not declared with any parameters. | test.c:17:6:17:22 | not_yet_declared1 | not_yet_declared1 |

Likely Bugs/Likely Typos/FutileParams.ql

void foo();

void bar(void);

void baz(int);

void test() {

foo(); // GOOD

foo(1); // BAD

bar(); // GOOD

baz(1); // GOOD

undeclared(1); // GOOD

not_yet_declared1(1); // BAD

not_yet_declared2(1); // GOOD

}

void not_yet_declared1();

void not_yet_declared2(int);

void cpp_varargs(...);

void bar();

void test() {

cpp_varargs(); // GOOD

cpp_varargs(1); // GOOD

__builtin_constant_p("something"); // GOOD: builtin

}