Clarify what verifier is

artem-smotrakov · artem-smotrakov · commit 651e43dee6f7 · 2022-02-12T12:24:48.000Z
diff --git a/java/ql/src/experimental/Security/CWE/CWE-297/CheckedHostnameVerification.java b/java/ql/src/experimental/Security/CWE/CWE-297/CheckedHostnameVerification.java
@@ -1,8 +1,10 @@
-SSLSocket socket = (SSLSocket) SSLSocketFactory.getDefault().createSocket(host, port);
-socket.startHandshake();
-boolean successful = verifier.verify(host, socket.getSession());
-if (!successful) {
-    socket.close();
-    throw new SSLException("Oops! Hostname verification failed!");
-}
-return socket;
+public SSLSocket connect(String host, int port, HostnameVerifier verifier) {
+    SSLSocket socket = (SSLSocket) SSLSocketFactory.getDefault().createSocket(host, port);
+    socket.startHandshake();
+    boolean successful = verifier.verify(host, socket.getSession());
+    if (!successful) {
+        socket.close();
+        throw new SSLException("Oops! Hostname verification failed!");
+    }
+    return socket;
+}
diff --git a/java/ql/src/experimental/Security/CWE/CWE-297/IgnoredHostnameVerification.java b/java/ql/src/experimental/Security/CWE/CWE-297/IgnoredHostnameVerification.java
@@ -1,4 +1,6 @@
-SSLSocket socket = (SSLSocket) SSLSocketFactory.getDefault().createSocket(host, port);
-socket.startHandshake();
-verifier.verify(host, socket.getSession());
-return socket;
+public SSLSocket connect(String host, int port, HostnameVerifier verifier) {
+    SSLSocket socket = (SSLSocket) SSLSocketFactory.getDefault().createSocket(host, port);
+    socket.startHandshake();
+    verifier.verify(host, socket.getSession());
+    return socket;
+}
