C++: There is no overlap between OutputWrite and RemoteFlowSinkFunction.

geoffw0 · geoffw0 · commit 66b9356eb948 · 2022-03-02T18:16:39.000Z
diff --git a/cpp/ql/src/Security/CWE/CWE-497/PotentiallyExposedSystemData.ql b/cpp/ql/src/Security/CWE/CWE-497/PotentiallyExposedSystemData.ql
@@ -40,7 +40,6 @@ class PotentiallyExposedSystemDataConfiguration extends TaintTracking::Configura
 
   override predicate isSink(DataFlow::Node sink) {
     exists(OutputWrite ow | ow.getASource() = sink.asExpr())
-    // TODO: eliminate duplication on remote flow sources?
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@ class PotentiallyExposedSystemDataConfiguration extends TaintTracking::Configura`
`40`	`40`
`41`	`41`	`override predicate isSink(DataFlow::Node sink) {`
`42`	`42`	`exists(OutputWrite ow \| ow.getASource() = sink.asExpr())`
`43`		`- // TODO: eliminate duplication on remote flow sources?`
`44`	`43`	`}`
`45`	`44`	`}`
`46`	`45`