Python: Apply suggestions from code review

RasmusWL · yoff · web-flow · commit 67ca14876ad0 · 2022-02-18T13:47:07.000+01:00
Co-authored-by: yoff &lt;lerchedahl@gmail.com&gt;
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
@@ -1979,7 +1979,7 @@ predicate clearsContent(Node n, Content c) {
 /**
  * Holds if values stored inside attribute `c` are cleared at node `n`.
  *
- * In `obj.foo = x` the any old value stored in `foo` is cleared at the pre-update node
+ * In `obj.foo = x` any old value stored in `foo` is cleared at the pre-update node
  * associated with `obj`
  */
 predicate attributeClearStep(Node n, AttributeContent c) {
diff --git a/python/ql/test/experimental/dataflow/coverage/argumentRoutingTest.ql b/python/ql/test/experimental/dataflow/coverage/argumentRoutingTest.ql
@@ -43,7 +43,7 @@ class Argument1RoutingConfig extends DataFlow::Configuration {
    * making it seem like we handle all cases even if we only handle the last one.
    * We make the test honest by preventing flow into source nodes.
    */
-  override predicate isBarrierIn(DataFlow::Node node) { isSource(node) }
+  override predicate isBarrierIn(DataFlow::Node node) { this.isSource(node) }
 }
 
 // for argument 2 and up, we use a generic approach. Change `maxNumArgs` below if we

Original file line number	Diff line number	Diff line change
`@@ -1979,7 +1979,7 @@ predicate clearsContent(Node n, Content c) {`
`1979`	`1979`	`/**`
`1980`	`1980`	* Holds if values stored inside attribute `c` are cleared at node `n`.
`1981`	`1981`	`*`
`1982`		- * In `obj.foo = x` the any old value stored in `foo` is cleared at the pre-update node
	`1982`	+ * In `obj.foo = x` any old value stored in `foo` is cleared at the pre-update node
`1983`	`1983`	* associated with `obj`
`1984`	`1984`	`*/`
`1985`	`1985`	`predicate attributeClearStep(Node n, AttributeContent c) {`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class Argument1RoutingConfig extends DataFlow::Configuration {`
`43`	`43`	`* making it seem like we handle all cases even if we only handle the last one.`
`44`	`44`	`* We make the test honest by preventing flow into source nodes.`
`45`	`45`	`*/`
`46`		`- override predicate isBarrierIn(DataFlow::Node node) { isSource(node) }`
	`46`	`+ override predicate isBarrierIn(DataFlow::Node node) { this.isSource(node) }`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	// for argument 2 and up, we use a generic approach. Change `maxNumArgs` below if we