Kotlin: Add abstract to concrete type cast guarded by when

tamasvajk · tamasvajk · commit 690d6517d752 · 2022-10-25T10:16:40.000+02:00
diff --git a/java/ql/test/kotlin/query-tests/AbstractToConcreteCollection/AbstractToConcreteCollection.expected b/java/ql/test/kotlin/query-tests/AbstractToConcreteCollection/AbstractToConcreteCollection.expected
@@ -0,0 +1 @@
+| Test.kt:3:9:3:9 | <implicit cast> | $@ is cast to the concrete type $@, losing abstraction. | file:///modules/java.base/java/util/List.class:0:0:0:0 | List | List<Integer> | file:///modules/java.base/java/util/ArrayList.class:0:0:0:0 | ArrayList | ArrayList<Integer> |
diff --git a/java/ql/test/kotlin/query-tests/AbstractToConcreteCollection/AbstractToConcreteCollection.qlref b/java/ql/test/kotlin/query-tests/AbstractToConcreteCollection/AbstractToConcreteCollection.qlref
@@ -0,0 +1 @@
+Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql
diff --git a/java/ql/test/kotlin/query-tests/AbstractToConcreteCollection/Test.kt b/java/ql/test/kotlin/query-tests/AbstractToConcreteCollection/Test.kt
@@ -0,0 +1,5 @@
+fun fn(m: MutableList<Int>) {
+    if (m is ArrayList) {
+        m.ensureCapacity(5)
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+\| Test.kt:3:9:3:9 \| <implicit cast> \| $@ is cast to the concrete type $@, losing abstraction. \| file:///modules/java.base/java/util/List.class:0:0:0:0 \| List \| List<Integer> \| file:///modules/java.base/java/util/ArrayList.class:0:0:0:0 \| ArrayList \| ArrayList<Integer> \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql`