update {cpp/java}/unused-local to match python

erik-krogh · erik-krogh · commit 698ccd8850cd · 2022-08-22T21:41:45.000+02:00
diff --git a/cpp/ql/src/Best Practices/Unused Entities/UnusedLocals.ql b/cpp/ql/src/Best Practices/Unused Entities/UnusedLocals.ql
@@ -58,4 +58,4 @@ where
   not exists(AsmStmt s | f = s.getEnclosingFunction()) and
   not v.getAnAttribute().getName() = "unused" and
   not any(ErrorExpr e).getEnclosingFunction() = f // unextracted expr may use `v`
-select v, "Variable " + v.getName() + " is not used"
+select v, "The value assigned to local variable '" + v.getName() + "' is never used."
diff --git a/java/ql/src/Violations of Best Practice/Dead Code/UnusedLocal.ql b/java/ql/src/Violations of Best Practice/Dead Code/UnusedLocal.ql
@@ -29,6 +29,4 @@ where
   // Rules about catch clauses belong in an exception handling query
   not exceptionVariable(ve) and
   not enhancedForVariable(ve)
-select v,
-  "Unused local variable " + v.getName() +
-    ". The variable is never read or written to and should be removed."
+select v, "The value assigned to local variable '" + v.getName() + "' is never used."
