Java: Member.getQualifiedName() tweaked

igfoo · igfoo · commit 6a63b86f8a53 · 2022-09-13T16:05:51.000+01:00
It now includes the qualified name of the declaring type.
diff --git a/java/ql/lib/change-notes/2022-09-13-Member-getQualifier.md b/java/ql/lib/change-notes/2022-09-13-Member-getQualifier.md
@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* The `Member.getQualifiedName()` predicate result now includes the qualified name of the declaring type.
diff --git a/java/ql/lib/semmle/code/java/Member.qll b/java/ql/lib/semmle/code/java/Member.qll
@@ -20,8 +20,12 @@ class Member extends Element, Annotatable, Modifiable, @member {
   /** Gets the type in which this member is declared. */
   RefType getDeclaringType() { declaresMember(result, this) }
 
-  /** Gets the qualified name of this member. */
-  string getQualifiedName() { result = this.getDeclaringType().getName() + "." + this.getName() }
+  /**
+   * Gets the qualified name of this member.
+   * This is useful for debugging, but for normal use `hasQualifiedName`
+   * is recommended, as it is more efficient.
+   */
+  string getQualifiedName() { result = this.getDeclaringType().getQualifiedName() + "." + this.getName() }
 
   /**
    * Holds if this member has the specified name and is declared in the
diff --git a/java/ql/lib/semmle/code/java/security/ExternalAPIs.qll b/java/ql/lib/semmle/code/java/security/ExternalAPIs.qll
@@ -93,8 +93,7 @@ class ExternalApiDataNode extends DataFlow::Node {
 
   /** Gets the description of the method being called. */
   string getMethodDescription() {
-    result =
-      this.getMethod().getDeclaringType().getPackage() + "." + this.getMethod().getQualifiedName()
+    result = this.getMethod().getQualifiedName()
   }
 }
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: minorAnalysis
 +---
 +* The `Member.getQualifiedName()` predicate result now includes the qualified name of the declaring type.
Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,7 @@ class ExternalApiDataNode extends DataFlow::Node {`
`93`	`93`
`94`	`94`	`/** Gets the description of the method being called. */`
`95`	`95`	`string getMethodDescription() {`
`96`		`- result =`
`97`		`- this.getMethod().getDeclaringType().getPackage() + "." + this.getMethod().getQualifiedName()`
	`96`	`+ result = this.getMethod().getQualifiedName()`
`98`	`97`	`}`
`99`	`98`	`}`
`100`	`99`