C++: Fix typo and adjust violation message wording.

geoffw0 · geoffw0 · commit 6e5729c9248a · 2022-03-03T10:28:53.000Z
diff --git a/cpp/ql/src/Security/CWE/CWE-497/PotentiallyExposedSystemData.ql b/cpp/ql/src/Security/CWE/CWE-497/PotentiallyExposedSystemData.ql
@@ -15,7 +15,7 @@
 /*
  * These queries are closely related:
  *  - `cpp/system-data-exposure`, which flags exposure of system information
- *    to a remote sink (i.e. focusses on qualiy of the sink).
+ *    to a remote sink (i.e. focusses on quality of the sink).
  *  - `cpp/potential-system-data-exposure`, which flags on exposure of the most
  *    sensitive information to a local sink (i.e. focusses on quality of the
  *    sensitive information).
@@ -48,5 +48,5 @@ from
   DataFlow::PathNode sink
 where config.hasFlowPath(source, sink)
 select sink, source, sink,
-  "This operation potentially exposes sensitive system data (a password or token) from $@.", source,
+  "This operation potentially exposes sensitive system data from $@.", source,
   source.getNode().toString()
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-497/SAMATE/PotentiallyExposedSystemData.expected b/cpp/ql/test/query-tests/Security/CWE/CWE-497/SAMATE/PotentiallyExposedSystemData.expected
@@ -7,5 +7,5 @@ nodes
 | tests.c:70:70:70:77 | array to pointer conversion | semmle.label | array to pointer conversion |
 subpaths
 #select
-| tests.c:70:70:70:77 | array to pointer conversion | tests.c:57:21:57:28 | array to pointer conversion | tests.c:70:70:70:77 | array to pointer conversion | This operation potentially exposes sensitive system data (a password or token) from $@. | tests.c:57:21:57:28 | array to pointer conversion | array to pointer conversion |
-| tests.c:70:70:70:77 | array to pointer conversion | tests.c:57:21:57:28 | password | tests.c:70:70:70:77 | array to pointer conversion | This operation potentially exposes sensitive system data (a password or token) from $@. | tests.c:57:21:57:28 | password | password |
+| tests.c:70:70:70:77 | array to pointer conversion | tests.c:57:21:57:28 | array to pointer conversion | tests.c:70:70:70:77 | array to pointer conversion | This operation potentially exposes sensitive system data from $@. | tests.c:57:21:57:28 | array to pointer conversion | array to pointer conversion |
+| tests.c:70:70:70:77 | array to pointer conversion | tests.c:57:21:57:28 | password | tests.c:70:70:70:77 | array to pointer conversion | This operation potentially exposes sensitive system data from $@. | tests.c:57:21:57:28 | password | password |
