C++ IR: Speed up getInstructionOperand

jbj · jbj · commit 6ee3def94219 · 2018-08-10T16:05:30.000+02:00
The `SSAConstruction::Cached::getInstructionOperand` predicate took
1m27s on a postgres snapshot before this change and was the slowest
predicate in SSAIR. It now takes 4.5s.

The slowdown was caused by its use of
`getUnmodeledDefinitionInstruction`, which got inlined into a place
where join orderer had little choice but to join the `MkInstruction`
relation with itself, creating a large intermediate relation.

I've added `pragma[noinline]` to `getUnmodeledDefinitionInstruction` and
also to similar predicates that are likely to cause the same problem in
the future.
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/FunctionIR.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/FunctionIR.qll
@@ -38,24 +38,28 @@ class FunctionIR extends TFunctionIR {
   /**
    * Gets the entry point for this function.
    */
+  pragma[noinline]
   final EnterFunctionInstruction getEnterFunctionInstruction() {
     result.getFunctionIR() = this
   }
 
   /**
    * Gets the exit point for this function.
    */
+  pragma[noinline]
   final ExitFunctionInstruction getExitFunctionInstruction() {
     result.getFunctionIR() = this
   }
 
+  pragma[noinline]
   final UnmodeledDefinitionInstruction getUnmodeledDefinitionInstruction() {
     result.getFunctionIR() = this
   }
 
   /**
    * Gets the single return instruction for this function.
    */
+  pragma[noinline]
   final ReturnInstruction getReturnInstruction() {
     result.getFunctionIR() = this
   }
@@ -64,13 +68,15 @@ class FunctionIR extends TFunctionIR {
    * Gets the variable used to hold the return value of this function. If this
    * function does not return a value, this predicate does not hold.
    */
+  pragma[noinline]
   final IRReturnVariable getReturnVariable() {
     result.getFunctionIR() = this
   }
   
   /**
    * Gets the block containing the entry point of this function.
    */  
+  pragma[noinline]
   final IRBlock getEntryBlock() {
     result.getFirstInstruction() = getEnterFunctionInstruction()
   }
diff --git a/cpp/ql/src/semmle/code/cpp/ssa/internal/aliased_ssa/FunctionIR.qll b/cpp/ql/src/semmle/code/cpp/ssa/internal/aliased_ssa/FunctionIR.qll
@@ -38,24 +38,28 @@ class FunctionIR extends TFunctionIR {
   /**
    * Gets the entry point for this function.
    */
+  pragma[noinline]
   final EnterFunctionInstruction getEnterFunctionInstruction() {
     result.getFunctionIR() = this
   }
 
   /**
    * Gets the exit point for this function.
    */
+  pragma[noinline]
   final ExitFunctionInstruction getExitFunctionInstruction() {
     result.getFunctionIR() = this
   }
 
+  pragma[noinline]
   final UnmodeledDefinitionInstruction getUnmodeledDefinitionInstruction() {
     result.getFunctionIR() = this
   }
 
   /**
    * Gets the single return instruction for this function.
    */
+  pragma[noinline]
   final ReturnInstruction getReturnInstruction() {
     result.getFunctionIR() = this
   }
@@ -64,13 +68,15 @@ class FunctionIR extends TFunctionIR {
    * Gets the variable used to hold the return value of this function. If this
    * function does not return a value, this predicate does not hold.
    */
+  pragma[noinline]
   final IRReturnVariable getReturnVariable() {
     result.getFunctionIR() = this
   }
   
   /**
    * Gets the block containing the entry point of this function.
    */  
+  pragma[noinline]
   final IRBlock getEntryBlock() {
     result.getFirstInstruction() = getEnterFunctionInstruction()
   }
diff --git a/cpp/ql/src/semmle/code/cpp/ssa/internal/ssa/FunctionIR.qll b/cpp/ql/src/semmle/code/cpp/ssa/internal/ssa/FunctionIR.qll
@@ -38,24 +38,28 @@ class FunctionIR extends TFunctionIR {
   /**
    * Gets the entry point for this function.
    */
+  pragma[noinline]
   final EnterFunctionInstruction getEnterFunctionInstruction() {
     result.getFunctionIR() = this
   }
 
   /**
    * Gets the exit point for this function.
    */
+  pragma[noinline]
   final ExitFunctionInstruction getExitFunctionInstruction() {
     result.getFunctionIR() = this
   }
 
+  pragma[noinline]
   final UnmodeledDefinitionInstruction getUnmodeledDefinitionInstruction() {
     result.getFunctionIR() = this
   }
 
   /**
    * Gets the single return instruction for this function.
    */
+  pragma[noinline]
   final ReturnInstruction getReturnInstruction() {
     result.getFunctionIR() = this
   }
@@ -64,13 +68,15 @@ class FunctionIR extends TFunctionIR {
    * Gets the variable used to hold the return value of this function. If this
    * function does not return a value, this predicate does not hold.
    */
+  pragma[noinline]
   final IRReturnVariable getReturnVariable() {
     result.getFunctionIR() = this
   }
   
   /**
    * Gets the block containing the entry point of this function.
    */  
+  pragma[noinline]
   final IRBlock getEntryBlock() {
     result.getFirstInstruction() = getEnterFunctionInstruction()
   }
