Fix XML comment processing

tamasvajk · tamasvajk · commit 7068a265a69e · 2021-02-04T08:42:39.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Analyser.cs b/csharp/extractor/Semmle.Extraction.CSharp/Analyser.cs
@@ -393,7 +393,7 @@ private void DoExtractTree(SyntaxTree tree)
             }
             catch (Exception ex)  // lgtm[cs/catch-of-all-exceptions]
             {
-                extractor.Message(new Message("Unhandled exception processing syntax tree", tree.FilePath, null, ex.StackTrace));
+                extractor.Message(new Message($"Unhandled exception processing syntax tree. {ex.Message}", tree.FilePath, null, ex.StackTrace));
             }
         }
 
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Populators/CommentPopulator.cs b/csharp/extractor/Semmle.Extraction.CSharp/Populators/CommentPopulator.cs
@@ -117,10 +117,6 @@ So we split it into separate lines
                         currentLocation = nextLineLocation;
                     }
                     break;
-                // Strangely, these are reported as SingleLineCommentTrivia.
-                case SyntaxKind.DocumentationCommentExteriorTrivia:
-                    cx.ModelError($"Unhandled comment type {trivia.Kind()} for {trivia}");
-                    break;
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ private void DoExtractTree(SyntaxTree tree)`
`393`	`393`	`}`
`394`	`394`	`catch (Exception ex) // lgtm[cs/catch-of-all-exceptions]`
`395`	`395`	`{`
`396`		`- extractor.Message(new Message("Unhandled exception processing syntax tree", tree.FilePath, null, ex.StackTrace));`
	`396`	`+ extractor.Message(new Message($"Unhandled exception processing syntax tree. {ex.Message}", tree.FilePath, null, ex.StackTrace));`
`397`	`397`	`}`
`398`	`398`	`}`
`399`	`399`
Original file line number	Diff line number	Diff line change
`@@ -117,10 +117,6 @@ So we split it into separate lines`
`117`	`117`	`currentLocation = nextLineLocation;`
`118`	`118`	`}`
`119`	`119`	`break;`
`120`		`- // Strangely, these are reported as SingleLineCommentTrivia.`
`121`		`- case SyntaxKind.DocumentationCommentExteriorTrivia:`
`122`		`- cx.ModelError($"Unhandled comment type {trivia.Kind()} for {trivia}");`
`123`		`- break;`
`124`	`120`	`}`
`125`	`121`	`}`
`126`	`122`	`}`