C++: Add false positive.

geoffw0 · geoffw0 · commit 720ac026dc86 · 2020-06-25T11:21:08.000+01:00
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/UsingStrcpyAsBoolean.expected b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/UsingStrcpyAsBoolean.expected
@@ -29,3 +29,4 @@
 | test.cpp:135:14:135:40 | ... && ... | Return value of strcpy used in a logical operation. |
 | test.cpp:137:14:137:40 | ... == ... | Return value of strcpy used in a logical operation. |
 | test.cpp:139:14:139:40 | ... != ... | Return value of strcpy used in a logical operation. |
+| test.cpp:159:9:159:16 | call to strcpy_s | Return value of strcpy_s used directly in a conditional expression. |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/test.cpp b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/test.cpp
@@ -156,7 +156,7 @@ void NegativeCases()
     {
     }
 
-    if (strcpy_s(szbuf1, 100, "test"))
+    if (strcpy_s(szbuf1, 100, "test")) // [FALSE POSITIVE]
     {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ void NegativeCases()`
`156`	`156`	`{`
`157`	`157`	`}`
`158`	`158`
`159`		`- if (strcpy_s(szbuf1, 100, "test"))`
	`159`	`+ if (strcpy_s(szbuf1, 100, "test")) // [FALSE POSITIVE]`
`160`	`160`	`{`
`161`	`161`	`}`
`162`	`162`