Java: Fix likely bug in ExposeRepresentation and re-autoformat.

aschackmull · aschackmull · commit 73f1beecfda6 · 2018-10-11T11:31:38.000+02:00
diff --git a/java/ql/src/Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql b/java/ql/src/Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
@@ -81,9 +81,11 @@ predicate mayWriteToArray(Expr modified) {
 
 predicate writesToArray(Expr array) {
   relevantType(array.getType()) and
-  (exists(Assignment a, ArrayAccess access | a.getDest() = access | access.getArray() = array))
-  or
-  exists(MethodAccess ma | ma.getQualifier() = array | modifyMethod(ma.getMethod()))
+  (
+    exists(Assignment a, ArrayAccess access | a.getDest() = access | access.getArray() = array)
+    or
+    exists(MethodAccess ma | ma.getQualifier() = array | modifyMethod(ma.getMethod()))
+  )
 }
 
 VarAccess modificationAfter(VarAccess v) {
