remove recvCls field from ActiveRecordModelClassMethodCall

alexrford · alexrford · commit 7439ab5635dc · 2021-06-17T14:42:42.000+01:00
diff --git a/ql/src/codeql_ruby/frameworks/ActiveRecord.qll b/ql/src/codeql_ruby/frameworks/ActiveRecord.qll
@@ -44,22 +44,15 @@ class ActiveRecordModelClass extends ClassDeclaration {
 
 /** A class method call whose receiver is an `ActiveRecordModelClass`. */
 class ActiveRecordModelClassMethodCall extends MethodCall {
-  // The model class that receives this call, if any
-  private ActiveRecordModelClass recvCls;
-
   ActiveRecordModelClassMethodCall() {
     // e.g. Foo.where(...)
-    recvCls.getModule() = resolveScopeExpr(this.getReceiver())
+    exists(ActiveRecordModelClass recvCls |
+      recvCls.getModule() = resolveScopeExpr(this.getReceiver())
+    )
     or
     // e.g. Foo.joins(:bars).where(...)
     this.getReceiver() instanceof ActiveRecordModelClassMethodCall
   }
-
-  // TODO: do we need this?
-  ActiveRecordModelClass getAnActiveRecordModelClass() {
-    result = recvCls or
-    result = this.getReceiver().(ActiveRecordModelClassMethodCall).getAnActiveRecordModelClass()
-  }
 }
 
 private predicate methodWithSqlFragmentArg(string methodName, int argIndex) {
