C++: Add a new test that demonstrates multiple out nodes.

MathiasVP · MathiasVP · commit 7439de37a30f · 2023-02-09T16:23:32.000Z
diff --git a/cpp/ql/test/library-tests/dataflow/dataflow-tests/test-number-of-outnodes.expected b/cpp/ql/test/library-tests/dataflow/dataflow-tests/test-number-of-outnodes.expected
@@ -0,0 +1,3 @@
+| dispatch.cpp:60:18:60:29 | Call: new | Unexpected result: ir-count(indirect return)=3 |
+| dispatch.cpp:61:18:61:29 | Call: new | Unexpected result: ir-count(indirect return)=3 |
+| dispatch.cpp:65:10:65:21 | Call: new | Unexpected result: ir-count(indirect return)=3 |
diff --git a/cpp/ql/test/library-tests/dataflow/dataflow-tests/test-number-of-outnodes.ql b/cpp/ql/test/library-tests/dataflow/dataflow-tests/test-number-of-outnodes.ql
@@ -0,0 +1,46 @@
+import TestUtilities.InlineExpectationsTest
+import cpp
+
+module AstTest {
+  private import semmle.code.cpp.dataflow.old.DataFlow::DataFlow
+  private import semmle.code.cpp.dataflow.old.internal.DataFlowPrivate
+
+  class ASTMultipleOutNodesTest extends InlineExpectationsTest {
+    ASTMultipleOutNodesTest() { this = "ASTMultipleOutNodesTest" }
+
+    override string getARelevantTag() { result = "ast-count(" + any(ReturnKind k).toString() + ")" }
+
+    override predicate hasActualResult(Location location, string element, string tag, string value) {
+      exists(DataFlowCall call, int n, ReturnKind kind |
+        call.getLocation() = location and
+        n = strictcount(getAnOutNode(call, kind)) and
+        n > 1 and
+        element = call.toString() and
+        tag = "ast-count(" + kind.toString() + ")" and
+        value = n.toString()
+      )
+    }
+  }
+}
+
+module IRTest {
+  private import semmle.code.cpp.ir.dataflow.DataFlow
+  private import semmle.code.cpp.ir.dataflow.internal.DataFlowPrivate
+
+  class IRMultipleOutNodesTest extends InlineExpectationsTest {
+    IRMultipleOutNodesTest() { this = "IRMultipleOutNodesTest" }
+
+    override string getARelevantTag() { result = "ir-count(" + any(ReturnKind k).toString() + ")" }
+
+    override predicate hasActualResult(Location location, string element, string tag, string value) {
+      exists(DataFlowCall call, int n, ReturnKind kind |
+        call.getLocation() = location and
+        n = strictcount(getAnOutNode(call, kind)) and
+        n > 1 and
+        element = call.toString() and
+        tag = "ir-count(" + kind.toString() + ")" and
+        value = n.toString()
+      )
+    }
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+\| dispatch.cpp:60:18:60:29 \| Call: new \| Unexpected result: ir-count(indirect return)=3 \|`
	`2`	`+\| dispatch.cpp:61:18:61:29 \| Call: new \| Unexpected result: ir-count(indirect return)=3 \|`
	`3`	`+\| dispatch.cpp:65:10:65:21 \| Call: new \| Unexpected result: ir-count(indirect return)=3 \|`