C++: Remove redundant case

jbj · jbj · commit 79d5b88e334f · 2020-03-20T19:40:53.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll
@@ -76,11 +76,6 @@ private module Cached {
     exists(OldInstruction oldInstruction | instruction = Chi(oldInstruction) |
       Alias::getResultMemoryLocation(oldInstruction).getVirtualVariable() instanceof
         Alias::AliasedVirtualVariable
-      or
-      // If there is no memory location for a memory result, then it's unmodeled
-      // and therefore conflated with every other unmodeled instruction.
-      oldInstruction.hasMemoryResult() and
-      not exists(Alias::getResultMemoryLocation(oldInstruction))
     )
     or
     exists(Alias::MemoryLocation location |
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll
@@ -76,11 +76,6 @@ private module Cached {
     exists(OldInstruction oldInstruction | instruction = Chi(oldInstruction) |
       Alias::getResultMemoryLocation(oldInstruction).getVirtualVariable() instanceof
         Alias::AliasedVirtualVariable
-      or
-      // If there is no memory location for a memory result, then it's unmodeled
-      // and therefore conflated with every other unmodeled instruction.
-      oldInstruction.hasMemoryResult() and
-      not exists(Alias::getResultMemoryLocation(oldInstruction))
     )
     or
     exists(Alias::MemoryLocation location |
diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll
@@ -76,11 +76,6 @@ private module Cached {
     exists(OldInstruction oldInstruction | instruction = Chi(oldInstruction) |
       Alias::getResultMemoryLocation(oldInstruction).getVirtualVariable() instanceof
         Alias::AliasedVirtualVariable
-      or
-      // If there is no memory location for a memory result, then it's unmodeled
-      // and therefore conflated with every other unmodeled instruction.
-      oldInstruction.hasMemoryResult() and
-      not exists(Alias::getResultMemoryLocation(oldInstruction))
     )
     or
     exists(Alias::MemoryLocation location |
