Merge pull request #9159 from github/nickrolfe/join_order_tweak

nickrolfe · web-flow · commit 79fb9e8fd200 · 2022-05-25T14:57:24.000+01:00
Ruby: tweak join order in `API::Impl::edge`
diff --git a/ruby/ql/lib/codeql/ruby/ApiGraphs.qll b/ruby/ql/lib/codeql/ruby/ApiGraphs.qll
@@ -576,7 +576,7 @@ module API {
         use(pred, a) and
         use(succ, b) and
         resolveConstant(b.asExpr().getExpr()) = resolveConstantWriteAccess(c) and
-        c.getSuperclassExpr() = a.asExpr().getExpr() and
+        pragma[only_bind_into](c).getSuperclassExpr() = a.asExpr().getExpr() and
         lbl = Label::subclass()
       )
       or

Original file line number	Diff line number	Diff line change
`@@ -576,7 +576,7 @@ module API {`
`576`	`576`	`use(pred, a) and`
`577`	`577`	`use(succ, b) and`
`578`	`578`	`resolveConstant(b.asExpr().getExpr()) = resolveConstantWriteAccess(c) and`
`579`		`- c.getSuperclassExpr() = a.asExpr().getExpr() and`
	`579`	`+ pragma[only_bind_into](c).getSuperclassExpr() = a.asExpr().getExpr() and`
`580`	`580`	`lbl = Label::subclass()`
`581`	`581`	`)`
`582`	`582`	`or`