Revert "import all the frameworks that extend RegexString"

erik-krogh · erik-krogh · commit 7e4ab4c60b80 · 2022-03-30T22:54:01.000+02:00
This reverts commit 84bc904. It caused ql/abstract-class-import alerts
diff --git a/python/ql/lib/semmle/python/regex.qll b/python/ql/lib/semmle/python/regex.qll
@@ -111,11 +111,6 @@ deprecated string mode_from_mode_object(Value obj) {
   )
 }
 
-// importing all the frameworks that extend `RegexString`.
-private import semmle.python.frameworks.Django as Django1
-private import semmle.python.frameworks.Tornado as Tornado1
-private import semmle.python.web.django.General as Django2
-
 /** A StrConst used as a regular expression */
 abstract class RegexString extends Expr {
   RegexString() { (this instanceof Bytes or this instanceof Unicode) }
diff --git a/python/ql/test/2/library-tests/locations/general/Locations.expected b/python/ql/test/2/library-tests/locations/general/Locations.expected
@@ -55,7 +55,6 @@
 | Dict | 46 | 54 | 46 | 55 |
 | Dict | 48 | 9 | 48 | 19 |
 | DictUnpacking | 46 | 52 | 46 | 55 |
-| DjangoViewClassHelper | 4 | 1 | 4 | 8 |
 | Ellipsis | 7 | 7 | 7 | 9 |
 | Ellipsis | 50 | 14 | 50 | 16 |
 | ExceptStmt | 32 | 9 | 32 | 31 |
diff --git a/python/ql/test/3/library-tests/locations/general/Locations.expected b/python/ql/test/3/library-tests/locations/general/Locations.expected
@@ -44,7 +44,6 @@
 | Dict | 46 | 54 | 46 | 55 |
 | Dict | 48 | 9 | 48 | 19 |
 | DictUnpacking | 46 | 52 | 46 | 55 |
-| DjangoViewClassHelper | 4 | 1 | 4 | 8 |
 | Ellipsis | 7 | 7 | 7 | 9 |
 | Ellipsis | 50 | 14 | 50 | 16 |
 | ExceptStmt | 32 | 9 | 32 | 31 |

Original file line number	Diff line number	Diff line change
`@@ -111,11 +111,6 @@ deprecated string mode_from_mode_object(Value obj) {`
`111`	`111`	`)`
`112`	`112`	`}`
`113`	`113`
`114`		-// importing all the frameworks that extend `RegexString`.
`115`		`-private import semmle.python.frameworks.Django as Django1`
`116`		`-private import semmle.python.frameworks.Tornado as Tornado1`
`117`		`-private import semmle.python.web.django.General as Django2`
`118`		`-`
`119`	`114`	`/** A StrConst used as a regular expression */`
`120`	`115`	`abstract class RegexString extends Expr {`
`121`	`116`	`RegexString() { (this instanceof Bytes or this instanceof Unicode) }`