Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 7e87e18

Browse files
RasmusWLRasmusWL
committed
Python: Adjust name/description/select of PamAuthorization.ql
Thought that calling out the actual vulnerability would make things easier for our end users :)
1 parent c84f693 commit 7e87e18

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎python/ql/src/experimental/Security/CWE-285/PamAuthorization.ql‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
2-
* @name Authorization bypass due to incorrect usage of PAM
3-
* @description Using only the `pam_authenticate` call to check the validity of a login can lead to a authorization bypass.
2+
* @name PAM authorization bypass due to incorrect usage
3+
* @description Not using `pam_acct_mgmt` after `pam_authenticate` to check the validity of a login can lead to authorization bypass.
44
* @kind problem
55
* @problem.severity warning
66
* @precision high
@@ -33,4 +33,5 @@ where
3333
acctMgmtCall = libPam().getMember("pam_acct_mgmt").getACall() and
3434
DataFlow::localFlow(handle, acctMgmtCall.getArg(0))
3535
)
36-
select authenticateCall, "This PAM authentication call may be lead to an authorization bypass."
36+
select authenticateCall,
37+
"This PAM authentication call may be lead to an authorization bypass, since 'pam_acct_mgmt' is not called afterwards."

‎python/ql/test/experimental/query-tests/Security/CWE-285/PamAuthorization.expected‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
| pam_test.py:48:18:48:44 | ControlFlowNode for pam_authenticate() | This PAM authentication call may be lead to an authorization bypass. |
1+
| pam_test.py:48:18:48:44 | ControlFlowNode for pam_authenticate() | This PAM authentication call may be lead to an authorization bypass, since 'pam_acct_mgmt' is not called afterwards. |

0 commit comments

Comments
 (0)