Rename UntrustedFlowSource to RemoteFlowSource

owen-mc · owen-mc · commit 81eaa6e32748 · 2024-04-17T21:35:50.000+01:00
Relaxed whole word requirement. Again skipped one instance in an old
change note.
diff --git a/go/ql/src/Security/CWE-640/EmailInjectionCustomizations.qll b/go/ql/src/Security/CWE-640/EmailInjectionCustomizations.qll
@@ -17,7 +17,7 @@ module EmailInjection {
   abstract class Sink extends DataFlow::Node { }
 
   /** A source of untrusted data, considered as a taint source for email injection. */
-  class UntrustedFlowSourceAsSource extends Source instanceof RemoteFlowSource { }
+  class RemoteFlowSourceAsSource extends Source instanceof RemoteFlowSource { }
 
   /**
    * A data-flow node that becomes part of an email considered as a taint sink for email injection.
diff --git a/go/ql/src/experimental/frameworks/Fiber.json b/go/ql/src/experimental/frameworks/Fiber.json
@@ -728,7 +728,7 @@
          ]
       },
       {
-         "Name": "UntrustedFlowSources",
+         "Name": "RemoteFlowSources",
          "Kind": "RemoteFlowSource",
          "Methods": [
             {
diff --git a/go/ql/src/experimental/frameworks/Fiber.qll b/go/ql/src/experimental/frameworks/Fiber.qll
@@ -295,8 +295,8 @@ private module Fiber {
   /**
    * Provides models of untrusted flow sources.
    */
-  private class UntrustedFlowSources extends RemoteFlowSource::Range {
-    UntrustedFlowSources() {
+  private class RemoteFlowSources extends RemoteFlowSource::Range {
+    RemoteFlowSources() {
       // Methods on types of package: github.com/gofiber/fiber@v1.14.6
       exists(string receiverName, string methodName, Method mtd, FunctionOutput out |
         this = out.getExitNode(mtd.getACall()) and
diff --git a/go/ql/test/experimental/frameworks/CleverGo/UntrustedSources.ql b/go/ql/test/experimental/frameworks/CleverGo/UntrustedSources.ql
@@ -2,7 +2,7 @@ import go
 import TestUtilities.InlineExpectationsTest
 import experimental.frameworks.CleverGo
 
-module UntrustedFlowSourceTest implements TestSig {
+module RemoteFlowSourceTest implements TestSig {
   string getARelevantTag() { result = "untrustedFlowSource" }
 
   predicate hasActualResult(Location location, string element, string tag, string value) {
@@ -20,4 +20,4 @@ module UntrustedFlowSourceTest implements TestSig {
   }
 }
 
-import MakeTest<UntrustedFlowSourceTest>
+import MakeTest<RemoteFlowSourceTest>
diff --git a/go/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go b/go/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go
diff --git a/go/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.ql b/go/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.ql
@@ -2,7 +2,7 @@ import go
 import TestUtilities.InlineExpectationsTest
 import experimental.frameworks.Fiber
 
-module UntrustedFlowSourceTest implements TestSig {
+module RemoteFlowSourceTest implements TestSig {
   string getARelevantTag() { result = "untrustedFlowSource" }
 
   predicate hasActualResult(Location location, string element, string tag, string value) {
@@ -20,4 +20,4 @@ module UntrustedFlowSourceTest implements TestSig {
   }
 }
 
-import MakeTest<UntrustedFlowSourceTest>
+import MakeTest<RemoteFlowSourceTest>
diff --git a/go/ql/test/library-tests/semmle/go/frameworks/ElazarlGoproxy/test.ql b/go/ql/test/library-tests/semmle/go/frameworks/ElazarlGoproxy/test.ql
@@ -1,7 +1,7 @@
 import go
 import TestUtilities.InlineExpectationsTest
 
-module UntrustedFlowSourceTest implements TestSig {
+module RemoteFlowSourceTest implements TestSig {
   string getARelevantTag() { result = "untrustedflowsource" }
 
   predicate hasActualResult(Location location, string element, string tag, string value) {
@@ -70,4 +70,4 @@ module TaintFlow implements TestSig {
   }
 }
 
-import MakeTest<MergeTests4<UntrustedFlowSourceTest, HeaderWriteTest, LoggerTest, TaintFlow>>
+import MakeTest<MergeTests4<RemoteFlowSourceTest, HeaderWriteTest, LoggerTest, TaintFlow>>
diff --git a/go/ql/test/library-tests/semmle/go/frameworks/GoKit/untrustedflowsource.ql b/go/ql/test/library-tests/semmle/go/frameworks/GoKit/untrustedflowsource.ql
@@ -1,7 +1,7 @@
 import go
 import TestUtilities.InlineExpectationsTest
 
-module UntrustedFlowSourceTest implements TestSig {
+module RemoteFlowSourceTest implements TestSig {
   string getARelevantTag() { result = "source" }
 
   predicate hasActualResult(Location location, string element, string tag, string value) {
@@ -16,4 +16,4 @@ module UntrustedFlowSourceTest implements TestSig {
   }
 }
 
-import MakeTest<UntrustedFlowSourceTest>
+import MakeTest<RemoteFlowSourceTest>
diff --git a/go/ql/test/library-tests/semmle/go/frameworks/Macaron/Sources.ql b/go/ql/test/library-tests/semmle/go/frameworks/Macaron/Sources.ql
@@ -1,7 +1,7 @@
 import go
 import TestUtilities.InlineExpectationsTest
 
-module UntrustedFlowSourceTest implements TestSig {
+module RemoteFlowSourceTest implements TestSig {
   string getARelevantTag() { result = "RemoteFlowSource" }
 
   predicate hasActualResult(Location location, string element, string tag, string value) {
@@ -15,4 +15,4 @@ module UntrustedFlowSourceTest implements TestSig {
   }
 }
 
-import MakeTest<UntrustedFlowSourceTest>
+import MakeTest<RemoteFlowSourceTest>

Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,7 @@`
`728`	`728`	`]`
`729`	`729`	`},`
`730`	`730`	`{`
`731`		`- "Name": "UntrustedFlowSources",`
	`731`	`+ "Name": "RemoteFlowSources",`
`732`	`732`	`"Kind": "RemoteFlowSource",`
`733`	`733`	`"Methods": [`
`734`	`734`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import go`
`2`	`2`	`import TestUtilities.InlineExpectationsTest`
`3`	`3`	`import experimental.frameworks.CleverGo`
`4`	`4`
`5`		`-module UntrustedFlowSourceTest implements TestSig {`
	`5`	`+module RemoteFlowSourceTest implements TestSig {`
`6`	`6`	`string getARelevantTag() { result = "untrustedFlowSource" }`
`7`	`7`
`8`	`8`	`predicate hasActualResult(Location location, string element, string tag, string value) {`
`@@ -20,4 +20,4 @@ module UntrustedFlowSourceTest implements TestSig {`
`20`	`20`	`}`
`21`	`21`	`}`
`22`	`22`
`23`		`-import MakeTest<UntrustedFlowSourceTest>`
	`23`	`+import MakeTest<RemoteFlowSourceTest>`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import go`
`2`	`2`	`import TestUtilities.InlineExpectationsTest`
`3`	`3`	`import experimental.frameworks.Fiber`
`4`	`4`
`5`		`-module UntrustedFlowSourceTest implements TestSig {`
	`5`	`+module RemoteFlowSourceTest implements TestSig {`
`6`	`6`	`string getARelevantTag() { result = "untrustedFlowSource" }`
`7`	`7`
`8`	`8`	`predicate hasActualResult(Location location, string element, string tag, string value) {`
`@@ -20,4 +20,4 @@ module UntrustedFlowSourceTest implements TestSig {`
`20`	`20`	`}`
`21`	`21`	`}`
`22`	`22`
`23`		`-import MakeTest<UntrustedFlowSourceTest>`
	`23`	`+import MakeTest<RemoteFlowSourceTest>`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import go`
`2`	`2`	`import TestUtilities.InlineExpectationsTest`
`3`	`3`
`4`		`-module UntrustedFlowSourceTest implements TestSig {`
	`4`	`+module RemoteFlowSourceTest implements TestSig {`
`5`	`5`	`string getARelevantTag() { result = "untrustedflowsource" }`
`6`	`6`
`7`	`7`	`predicate hasActualResult(Location location, string element, string tag, string value) {`
`@@ -70,4 +70,4 @@ module TaintFlow implements TestSig {`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`
`73`		`-import MakeTest<MergeTests4<UntrustedFlowSourceTest, HeaderWriteTest, LoggerTest, TaintFlow>>`
	`73`	`+import MakeTest<MergeTests4<RemoteFlowSourceTest, HeaderWriteTest, LoggerTest, TaintFlow>>`