CPP: Correct the tests.

geoffw0 · geoffw0 · commit 821d5061a7ef · 2019-11-08T15:10:13.000Z
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Linux_signed_chars/a.c b/cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Linux_signed_chars/a.c
@@ -9,8 +9,8 @@ void myMultiplyDefinedPrintf2(const char *format, const char *extraArg, ...);
 
 void test_custom_printf1()
 {
-  myMultiplyDefinedPrintf("%i", "%s", 1); // GOOD
-  myMultiplyDefinedPrintf("%i", "%s", 1.0f); // BAD [NOT DETECTED]
-  myMultiplyDefinedPrintf2("%i", "%s", 1); // GOOD (we can't tell which definition is correct so we have to assume this is OK)
-  myMultiplyDefinedPrintf2("%i", "%s", 1.0f); // GOOD (we can't tell which definition is correct so we have to assume this is OK)
+  myMultiplyDefinedPrintf("%i", "%f", 1); // GOOD
+  myMultiplyDefinedPrintf("%i", "%f", 1.0f); // BAD [NOT DETECTED]
+  myMultiplyDefinedPrintf2("%i", "%f", 1); // GOOD (we can't tell which definition is correct so we have to assume this is OK)
+  myMultiplyDefinedPrintf2("%i", "%f", 1.0f); // GOOD (we can't tell which definition is correct so we have to assume this is OK)
 }

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,8 @@ void myMultiplyDefinedPrintf2(const char format, const char extraArg, ...);`
`9`	`9`
`10`	`10`	`void test_custom_printf1()`
`11`	`11`	`{`
`12`		`- myMultiplyDefinedPrintf("%i", "%s", 1); // GOOD`
`13`		`- myMultiplyDefinedPrintf("%i", "%s", 1.0f); // BAD [NOT DETECTED]`
`14`		`- myMultiplyDefinedPrintf2("%i", "%s", 1); // GOOD (we can't tell which definition is correct so we have to assume this is OK)`
`15`		`- myMultiplyDefinedPrintf2("%i", "%s", 1.0f); // GOOD (we can't tell which definition is correct so we have to assume this is OK)`
	`12`	`+ myMultiplyDefinedPrintf("%i", "%f", 1); // GOOD`
	`13`	`+ myMultiplyDefinedPrintf("%i", "%f", 1.0f); // BAD [NOT DETECTED]`
	`14`	`+ myMultiplyDefinedPrintf2("%i", "%f", 1); // GOOD (we can't tell which definition is correct so we have to assume this is OK)`
	`15`	`+ myMultiplyDefinedPrintf2("%i", "%f", 1.0f); // GOOD (we can't tell which definition is correct so we have to assume this is OK)`
`16`	`16`	`}`