Python: Remove redundant inline casts

tausbn · web-flow · commit 821de636af5b · 2022-03-04T12:21:31.000Z
These are all implied by the return type of the other side of the
equality.
diff --git a/python/ql/lib/semmle/python/frameworks/Django.qll b/python/ql/lib/semmle/python/frameworks/Django.qll
@@ -1873,7 +1873,7 @@ module PrivateDjango {
     /** Gets a reference to this class. */
     private DataFlow::TypeTrackingNode getARef(DataFlow::TypeTracker t) {
       t.start() and
-      result.asExpr().(ClassExpr) = this.getParent()
+      result.asExpr() = this.getParent()
       or
       exists(DataFlow::TypeTracker t2 | result = this.getARef(t2).track(t2, t))
     }
diff --git a/python/ql/lib/semmle/python/frameworks/Flask.qll b/python/ql/lib/semmle/python/frameworks/Flask.qll
@@ -193,7 +193,7 @@ module Flask {
 
     FlaskViewClass() {
       this.getABase() = Views::View::subclassRef().getAUse().asExpr() and
-      api_node.getAnImmediateUse().asExpr().(ClassExpr) = this.getParent()
+      api_node.getAnImmediateUse().asExpr() = this.getParent()
     }
 
     /** Gets a function that could handle incoming requests, if any. */
@@ -218,7 +218,7 @@ module Flask {
   class FlaskMethodViewClass extends FlaskViewClass {
     FlaskMethodViewClass() {
       this.getABase() = Views::MethodView::subclassRef().getAUse().asExpr() and
-      api_node.getAnImmediateUse().asExpr().(ClassExpr) = this.getParent()
+      api_node.getAnImmediateUse().asExpr() = this.getParent()
     }
 
     override Function getARequestHandler() {
@@ -299,7 +299,7 @@ module Flask {
     override Function getARequestHandler() {
       exists(DataFlow::LocalSourceNode func_src |
         func_src.flowsTo(this.getViewArg()) and
-        func_src.asExpr().(CallableExpr) = result.getDefinition()
+        func_src.asExpr() = result.getDefinition()
       )
       or
       exists(FlaskViewClass vc |
diff --git a/python/ql/lib/semmle/python/frameworks/Tornado.qll b/python/ql/lib/semmle/python/frameworks/Tornado.qll
@@ -102,7 +102,7 @@ private module Tornado {
           /** Gets a reference to this class. */
           private DataFlow::TypeTrackingNode getARef(DataFlow::TypeTracker t) {
             t.start() and
-            result.asExpr().(ClassExpr) = this.getParent()
+            result.asExpr() = this.getParent()
             or
             exists(DataFlow::TypeTracker t2 | result = this.getARef(t2).track(t2, t))
           }

Original file line number	Diff line number	Diff line change
`@@ -1873,7 +1873,7 @@ module PrivateDjango {`
`1873`	`1873`	`/** Gets a reference to this class. */`
`1874`	`1874`	`private DataFlow::TypeTrackingNode getARef(DataFlow::TypeTracker t) {`
`1875`	`1875`	`t.start() and`
`1876`		`- result.asExpr().(ClassExpr) = this.getParent()`
	`1876`	`+ result.asExpr() = this.getParent()`
`1877`	`1877`	`or`
`1878`	`1878`	`exists(DataFlow::TypeTracker t2 \| result = this.getARef(t2).track(t2, t))`
`1879`	`1879`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ private module Tornado {`
`102`	`102`	`/** Gets a reference to this class. */`
`103`	`103`	`private DataFlow::TypeTrackingNode getARef(DataFlow::TypeTracker t) {`
`104`	`104`	`t.start() and`
`105`		`- result.asExpr().(ClassExpr) = this.getParent()`
	`105`	`+ result.asExpr() = this.getParent()`
`106`	`106`	`or`
`107`	`107`	`exists(DataFlow::TypeTracker t2 \| result = this.getARef(t2).track(t2, t))`
`108`	`108`	`}`