Add method access qualifier as source

luchua-bc · web-flow · commit 87668bf0756c · 2020-06-27T18:00:52.000-04:00
diff --git a/java/ql/src/semmle/code/java/dataflow/FlowSources.qll b/java/ql/src/semmle/code/java/dataflow/FlowSources.qll
@@ -298,7 +298,10 @@ private class AndroidIntentExtraSource extends RemoteFlowSource {
   AndroidIntentExtraSource() {
     exists(MethodAccess ma |
       ma instanceof IntentGetExtraMethodAccess and
-      this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma
+      (
+        this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma or
+        ma.getQualifier() = this.asExpr()
+      )
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,10 @@ private class AndroidIntentExtraSource extends RemoteFlowSource {`
`298`	`298`	`AndroidIntentExtraSource() {`
`299`	`299`	`exists(MethodAccess ma \|`
`300`	`300`	`ma instanceof IntentGetExtraMethodAccess and`
`301`		`- this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma`
	`301`	`+ (`
	`302`	`+ this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma or`
	`303`	`+ ma.getQualifier() = this.asExpr()`
	`304`	`+ )`
`302`	`305`	`)`
`303`	`306`	`}`
`304`	`307`