Apply suggestions from code review

alexrford · aibaars · web-flow · commit 89be8d87107b · 2021-05-13T12:59:16.000+01:00
Co-authored-by: Arthur Baars &lt;aibaars@github.com&gt;
diff --git a/ql/src/queries/security/cwe-732/WeakFilePermissions.ql b/ql/src/queries/security/cwe-732/WeakFilePermissions.ql
@@ -52,8 +52,8 @@ class PermissivePermissionsExpr extends Expr {
       (acc = access(world_permission(perm)) or acc = access(group_permission(perm)))
     )
     or
-    // adding/setting read or write permissions for all/group/owner
-    this.(StringLiteral).getValueText().regexpMatch(".*[ago][^-=+]*[+=]*[xXst]*[rw].*")
+    // adding/setting read or write permissions for all/group/other
+    this.(StringLiteral).getValueText().regexpMatch(".*[ago][^-=+]*[+=][xXst]*[rw].*")
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ class PermissivePermissionsExpr extends Expr {`
`52`	`52`	`(acc = access(world_permission(perm)) or acc = access(group_permission(perm)))`
`53`	`53`	`)`
`54`	`54`	`or`
`55`		`- // adding/setting read or write permissions for all/group/owner`
`56`		`- this.(StringLiteral).getValueText().regexpMatch(".[ago][^-=+][+=][xXst][rw].*")`
	`55`	`+ // adding/setting read or write permissions for all/group/other`
	`56`	`+ this.(StringLiteral).getValueText().regexpMatch(".[ago][^-=+][+=][xXst][rw].")`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`