Remove filter to see all unsupported APIs

Benjamin Muskalla · Benjamin Muskalla · commit 89f4a35273db · 2021-08-16T15:40:53.000+02:00
diff --git a/java/ql/src/Telemetry/ExternalAPI.qll b/java/ql/src/Telemetry/ExternalAPI.qll
@@ -13,16 +13,6 @@ class ExternalAPI extends Callable {
   /** Holds true if this API is part of a common testing library or framework */
   predicate isTestLibrary() { getDeclaringType() instanceof TestLibrary }
 
-  /** Holds true if this API has inputs or outputs that are interesting to support by CodeQL. */
-  predicate isInteresting() {
-    getNumberOfParameters() > 0 and
-    exists(Type retType | retType = getReturnType() |
-      not retType instanceof VoidType and
-      not retType instanceof PrimitiveType and
-      not retType instanceof BoxedType
-    )
-  }
-
   /**
    * Gets information about the external API in the form expected by the CSV modeling framework.
    */
diff --git a/java/ql/src/Telemetry/ExternalAPIUsages.ql b/java/ql/src/Telemetry/ExternalAPIUsages.ql
@@ -14,8 +14,7 @@ import semmle.code.java.GeneratedFiles
 from ExternalAPI api
 where
   not api.isTestLibrary() and
-  not api.isSupported() and
-  api.isInteresting()
+  not api.isSupported()
 select api.asCSV(api) as csv,
   strictcount(Call c |
     c.getCallee() = api and
