Factor out creating upgrade.properties into a function

jketema · jketema · commit 8ad0d8ea69e3 · 2022-02-16T10:54:12.000+01:00
diff --git a/misc/scripts/prepare-db-upgrade.sh b/misc/scripts/prepare-db-upgrade.sh
@@ -124,18 +124,22 @@ if [ "${current_hash}" = "${prev_hash}" ]; then
   exit
 fi
 
+create_upgrade_properties()
+{
+  cat <<EOF > "$1/upgrade.properties"
+description: <INSERT DESCRIPTION HERE>
+compatibility: full|backwards|partial|breaking
+EOF
+}
+
 # Copy current and new dbscheme into the upgrade dir
 upgradedir="${upgrade_root}/${prev_hash}"
 mkdir -p "${upgradedir}"
 
 cp "${scheme_file}" "${upgradedir}"
 git cat-file blob "${prev_hash}" > "${upgradedir}/old.dbscheme"
 
-# Create the template upgrade.properties file in the upgrade dir.
-cat <<EOF > "${upgradedir}/upgrade.properties"
-description: <INSERT DESCRIPTION HERE>
-compatibility: full|backwards|partial|breaking
-EOF
+create_upgrade_properties "${upgradedir}"
 
 # Copy current and new dbscheme into the downgrade dir
 downgradedir="${downgrade_root}/${current_hash}"
@@ -144,11 +148,7 @@ mkdir -p "${downgradedir}"
 cp "${scheme_file}" "${downgradedir}/old.dbscheme"
 git cat-file blob "${prev_hash}" > "${downgradedir}/$(basename "${scheme_file}")"
 
-# Create the template upgrade.properties file in the downgrade dir.
-cat <<EOF > "${downgradedir}/upgrade.properties"
-description: <INSERT DESCRIPTION HERE>
-compatibility: full|backwards|partial|breaking
-EOF
+create_upgrade_properties "${downgradedir}"
 
 # Tell user what we've done
 cat <<EOF
