Python: Minor SQLALchemy comment fixes

RasmusWL · RasmusWL · commit 8badba26b823 · 2021-09-22T13:58:29.000+02:00
diff --git a/python/ql/lib/semmle/python/frameworks/SqlAlchemy.qll b/python/ql/lib/semmle/python/frameworks/SqlAlchemy.qll
@@ -300,10 +300,9 @@ module SqlAlchemy {
    *   there are many many constructs we would need to have models for. (see the 2
    *   examples below)
    *
-   * So instead we flag user-input to a TextClause with its' own query
-   * (`py/sqlalchemy-textclause-injection`). And so we don't highlight any parts of an
-   * ORM constructed query such as these as containing SQL, and don't need the additional
-   * taint steps either.
+   * So instead we extended the SQL injection query to include TextClause construction
+   * as a sink. And so we don't highlight any parts of an ORM constructed query such as
+   * these as containing SQL, and don't need the additional taint steps either.
    *
    * See
    * - https://docs.sqlalchemy.org/en/14/core/sqlelement.html#sqlalchemy.sql.expression.TextClause.
diff --git a/python/ql/test/library-tests/frameworks/sqlalchemy/new_tests.py b/python/ql/test/library-tests/frameworks/sqlalchemy/new_tests.py
@@ -202,8 +202,8 @@ class For14(Base):
 # - This would require a LOT of modeling for these additional taint steps, since there
 #   are many many constructs we would need to have models for. (see the 2 examples below)
 #
-# So instead we flag user-input to a TextClause with its' own query. And so we don't
-# highlight any parts of an ORM constructed query such as these as containing SQL.
+# So instead we extended the SQL injection query to include TextClause construction as a
+# sink directly.
 
 # `filter` provides more general filtering
 # see https://docs.sqlalchemy.org/en/14/orm/tutorial.html#common-filter-operators

Original file line number	Diff line number	Diff line change
`@@ -300,10 +300,9 @@ module SqlAlchemy {`
`300`	`300`	`* there are many many constructs we would need to have models for. (see the 2`
`301`	`301`	`* examples below)`
`302`	`302`	`*`
`303`		`- * So instead we flag user-input to a TextClause with its' own query`
`304`		- * (`py/sqlalchemy-textclause-injection`). And so we don't highlight any parts of an
`305`		`- * ORM constructed query such as these as containing SQL, and don't need the additional`
`306`		`- * taint steps either.`
	`303`	`+ * So instead we extended the SQL injection query to include TextClause construction`
	`304`	`+ * as a sink. And so we don't highlight any parts of an ORM constructed query such as`
	`305`	`+ * these as containing SQL, and don't need the additional taint steps either.`
`307`	`306`	`*`
`308`	`307`	`* See`
`309`	`308`	`* - https://docs.sqlalchemy.org/en/14/core/sqlelement.html#sqlalchemy.sql.expression.TextClause.`