replace forex with unique in DOM.qll

erik-krogh · erik-krogh · commit 8c19f7810db8 · 2021-02-24T17:59:38.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/DOM.qll b/javascript/ql/src/semmle/javascript/DOM.qll
@@ -344,7 +344,7 @@ module DOM {
         or
         exists(JQuery::MethodCall call | this = call and call.getMethodName() = "get" |
           call.getNumArgument() = 1 and
-          forex(InferredType t | t = call.getArgument(0).analyze().getAType() | t = TTNumber())
+          unique(InferredType t | t = call.getArgument(0).analyze().getAType()) = TTNumber()
         )
         or
         // A `this` node from a callback given to a `$().each(callback)` call.

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ module DOM {`
`344`	`344`	`or`
`345`	`345`	`exists(JQuery::MethodCall call \| this = call and call.getMethodName() = "get" \|`
`346`	`346`	`call.getNumArgument() = 1 and`
`347`		`- forex(InferredType t \| t = call.getArgument(0).analyze().getAType() \| t = TTNumber())`
	`347`	`+ unique(InferredType t \| t = call.getArgument(0).analyze().getAType()) = TTNumber()`
`348`	`348`	`)`
`349`	`349`	`or`
`350`	`350`	// A `this` node from a callback given to a `$().each(callback)` call.