JS: add test

asger-semmle · asger-semmle · commit 8e8085ea1f80 · 2019-02-28T10:09:36.000Z
diff --git a/javascript/ql/test/query-tests/Security/CWE-020/IncorrectSuffixCheck.expected b/javascript/ql/test/query-tests/Security/CWE-020/IncorrectSuffixCheck.expected
@@ -8,3 +8,4 @@
 | tst.js:55:32:55:71 | x.index ... gth - 1 | This suffix check is missing a length comparison to correctly handle indexOf returning -1. |
 | tst.js:67:32:67:71 | x.index ... gth - 1 | This suffix check is missing a length comparison to correctly handle indexOf returning -1. |
 | tst.js:76:25:76:57 | index = ... gth - 1 | This suffix check is missing a length comparison to correctly handle indexOf returning -1. |
+| tst.js:80:10:80:57 | x.index ... th + 1) | This suffix check is missing a length comparison to correctly handle indexOf returning -1. |
diff --git a/javascript/ql/test/query-tests/Security/CWE-020/tst.js b/javascript/ql/test/query-tests/Security/CWE-020/tst.js
@@ -75,3 +75,7 @@ function withIndexOfCheckBad(x, y) {
   let index = x.indexOf(y);
   return index !== 0 && index === x.length - y.length - 1; // NOT OK
 }
+
+function plus(x, y) {
+  return x.indexOf("." + y) === x.length - (y.length + 1); // NOT OK
+}

Original file line number	Diff line number	Diff line change
`@@ -75,3 +75,7 @@ function withIndexOfCheckBad(x, y) {`
`75`	`75`	`let index = x.indexOf(y);`
`76`	`76`	`return index !== 0 && index === x.length - y.length - 1; // NOT OK`
`77`	`77`	`}`
	`78`	`+`
	`79`	`+function plus(x, y) {`
	`80`	`+ return x.indexOf("." + y) === x.length - (y.length + 1); // NOT OK`
	`81`	`+}`