C++: Fix test comments.

geoffw0 · geoffw0 · commit 8f270b665c0f · 2021-11-30T08:56:24.000Z
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-295/test2.cpp b/cpp/ql/test/query-tests/Security/CWE/CWE-295/test2.cpp
@@ -97,7 +97,7 @@ bool test2_8(SSL *ssl)
 {
 	int cert;
 
-	cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert) [FALSE POSITIVE]
+	cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert)
 	if (!cert) return false;
 	if (!SSL_get_verify_result(ssl)) return false;
 
@@ -108,7 +108,7 @@ bool test2_9(SSL *ssl)
 {
 	int cert;
 
-	cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert) [FALSE POSITIVE]
+	cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert)
 	if ((!cert) || (SSL_get_verify_result(ssl) != 0)) {
 		return false;
 	}
@@ -137,7 +137,7 @@ bool test2_11(SSL *ssl)
 {
 	int cert;
 
-	cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert) [FALSE POSITIVE]
+	cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert)
 
 	if ((cert) && (SSL_get_verify_result(ssl) == 0)) {
 		return true;

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ bool test2_8(SSL *ssl)`
`97`	`97`	`{`
`98`	`98`	`int cert;`
`99`	`99`
`100`		`- cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert) [FALSE POSITIVE]`
	`100`	`+ cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert)`
`101`	`101`	`if (!cert) return false;`
`102`	`102`	`if (!SSL_get_verify_result(ssl)) return false;`
`103`	`103`
`@@ -108,7 +108,7 @@ bool test2_9(SSL *ssl)`
`108`	`108`	`{`
`109`	`109`	`int cert;`
`110`	`110`
`111`		`- cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert) [FALSE POSITIVE]`
	`111`	`+ cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert)`
`112`	`112`	`if ((!cert) \|\| (SSL_get_verify_result(ssl) != 0)) {`
`113`	`113`	`return false;`
`114`	`114`	`}`
`@@ -137,7 +137,7 @@ bool test2_11(SSL *ssl)`
`137`	`137`	`{`
`138`	`138`	`int cert;`
`139`	`139`
`140`		`- cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert) [FALSE POSITIVE]`
	`140`	`+ cert = SSL_get_peer_certificate(ssl); // GOOD (SSL_get_verify_result is called when there is a cert)`
`141`	`141`
`142`	`142`	`if ((cert) && (SSL_get_verify_result(ssl) == 0)) {`
`143`	`143`	`return true;`